Closed Bug 843618 Opened 7 years ago Closed 7 years ago
Change CSS pixels values from preferences breaks screenshoots
34.55 KB, image/png
27.58 KB, image/png
18.72 KB, image/png
1.91 KB, patch
|Details | Diff | Splinter Review|
Install on the device latest Gaia code with custom-prefs.js and this values: pref("layout.css.devPixelsPerPx", "1.6875"); When you perform a screenshot the content is splited off but the file dimensions seems to be OK.
Seems that it could be related with https://bugzilla.mozilla.org/show_bug.cgi?id=828531
It is probably not related to bug 828531. Ismael, what did you do to generate those attachments?
Assignee: ncameron → nobody
Just run the Peak device with pref("layout.css.devPixelsPerPx", "1.6875"); and perform an screenshoot
7 years ago
Assignee: nobody → roc
I added pref("layout.css.devPixelsPerPx", "1.6875") to custom-prefs.js, installed it on Unagi, and indeed the layout was zoomed (and somewhat broken, unsurprisingly). Starting apps and then long-pressing the Home key brought up the card view and the screenshots in that view looked fine. Also, the screenshots we show while an app starts up seemed to look fine. Am I testing this wrong?
Oh, you meant the home-power screenshot feature. I see the bug now.
The bug is in BasicShadowLayerManager::EndTransaction, where we ask the remoteRenderer to give us a copy of its buffer which we then copy to the destination context (in this case, the drawWindow destination). We set the size of the snapshot buffer to the size of the destination context's underlying surface, which is wrong in this case because the destination context is scaling by 0.6, so we want a larger snapshot which we will scale down to fill the destination context.
I'm not sure who should review this, feel free to pass it on.
Attachment #721991 - Flags: review?(jmuizelaar)
Comment on attachment 721991 [details] [diff] [review] fix Review of attachment 721991 [details] [diff] [review]: ----------------------------------------------------------------- This seems sane to me. You should also check if we'll need something similar on gfx branch.
Attachment #721991 - Flags: review?(jmuizelaar) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Do we need this on the b2g18 branch?
Well i think so Robert!
Comment on attachment 721991 [details] [diff] [review] fix NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): none User impact if declined: screenshots in high-DPI FirefoxOS configurations are generally broken Testing completed: been on mozilla-central for a while Risk to taking this patch (and alternatives if risky): pretty low risk. Only affects screenshotting. String or UUID changes made by this patch: none
Attachment #721991 - Flags: approval-mozilla-b2g18?
Attachment #721991 - Flags: approval-mozilla-b2g18? → approval-mozilla-b2g18+
You need to log in before you can comment on or make changes to this bug.