Force run_jetpack.py to test the SDK modules

RESOLVED FIXED

Status

Release Engineering
General Automation
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
We're adding support to the SDK so it can use the modules now shipping in Firefox. We want to make sure that run_jetpack.py ignores those modules in Firefox though so we need to add an extra flag to the command line we call cfx with.
(Assignee)

Comment 1

5 years ago
Created attachment 716668 [details] [diff] [review]
patch rev 1

Comment 2

5 years ago
Would any patches need to be uplifted to mozilla-aurora?
or the code is already there?
(Assignee)

Comment 3

5 years ago
(In reply to Armen Zambrano G. [:armenzg] from comment #2)
> Would any patches need to be uplifted to mozilla-aurora?
> or the code is already there?

run_jetpack.py is only in use on the Jetpack tree now unless I'm forgetting something, and that tree always runs against the latest SDK version so this change should work, in fact it fixes some test failures on that tree where it is attempting to use older APIs from Firefox right now.
(Assignee)

Comment 4

5 years ago
Comment on attachment 716668 [details] [diff] [review]
patch rev 1

Can you review this Armen?
Attachment #716668 - Flags: review?(armenzg)

Comment 5

5 years ago
Comment on attachment 716668 [details] [diff] [review]
patch rev 1

Review of attachment 716668 [details] [diff] [review]:
-----------------------------------------------------------------

It looks good to me. Would you like me to test it on staging before landing it?
Attachment #716668 - Flags: review?(armenzg) → review+
(Assignee)

Comment 6

5 years ago
(In reply to Armen Zambrano G. [:armenzg] from comment #5)
> Comment on attachment 716668 [details] [diff] [review]
> patch rev 1
> 
> Review of attachment 716668 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> It looks good to me. Would you like me to test it on staging before landing
> it?

I don't think it's worth it, I'll just land it then I have a whitespace change to push to the SDK anyway that will trigger a full set of builds.

Thanks

Comment 7

5 years ago
It won't use the new code until the code merges from default to production on buildbot-configs.
(Assignee)

Comment 8

5 years ago
(In reply to Armen Zambrano G. [:armenzg] from comment #7)
> It won't use the new code until the code merges from default to production
> on buildbot-configs.

In the past changes to run_jetpack.py have taken effect immediately.

https://hg.mozilla.org/build/tools/rev/6489651f9a28
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 9

5 years ago
(In reply to Dave Townsend (:Mossop) from comment #8)
> (In reply to Armen Zambrano G. [:armenzg] from comment #7)
> > It won't use the new code until the code merges from default to production
> > on buildbot-configs.
> 
> In the past changes to run_jetpack.py have taken effect immediately.
> 
> https://hg.mozilla.org/build/tools/rev/6489651f9a28

My bad. I was thinking of the wrong repo. I didn't notice that it was against tools.
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.