Closed
Bug 843729
Opened 11 years ago
Closed 11 years ago
b2gautomation.py uses invalid devicemanager.deviceSerial
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla22
People
(Reporter: jgriffin, Assigned: jgriffin)
Details
Attachments
(1 file)
|
899 bytes,
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
devicemanager's deviceSerial was renamed to _deviceSerial some time ago; there's still one reference to the former in b2gautomation.py, which prevents B2G mochitests from being run on real devices.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #716691 -
Flags: review?(ahalberstadt)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 716691 [details] [diff] [review] deviceSerial -> _deviceSerial, Review of attachment 716691 [details] [diff] [review]: ----------------------------------------------------------------- Ouch, good catch
Attachment #716691 -
Flags: review?(ahalberstadt) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/353df9231150
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/353df9231150
Assignee: nobody → jgriffin
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•