Bug 840322 pretty carefully set things up so there could only be one pending request for the settings DB, but attachment 715842 [details] [diff] [review] regressed this. We now consistently see two getAll() requests, which is going to contribute the problem in bug 842215 and regress memory usage as well.
Created attachment 716711 [details] [diff] [review] Fix regression
5 years ago
blocking-b2g: --- → tef?
5 years ago
Comment on attachment 716711 [details] [diff] [review] Fix regression I tried the same way to prevent multiple query on bug 842215, and verified it works.
Attachment #716711 - Flags: review+
CC'ing offender :-/
(You'll want to grab this one, if you haven't already.)
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #3) > CC'ing offender :-/ BTW, no worries; the invariant maintained by the original code was fairly subtle (sorry! my fault), and we don't have any performance tests that would have caught regressions from violating it.
Can this land in preparation for uplift?
status-b2g18: --- → affected
status-b2g18-v1.0.0: --- → wontfix
status-b2g18-v1.0.1: --- → affected
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(There was a small typo in the commit. [sic])
status-b2g18: affected → fixed
status-b2g18-v1.0.1: affected → fixed
Cannot verify, need steps to blackbox test this issue.
Whiteboard: [target 28/2] QARegressExclude → [target 28/2] QARegressExclude, [qa-]
You need to log in before you can comment on or make changes to this bug.