843762 - Settings can read DB multiple times on startup, again

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Bug 840322 pretty carefully set things up so there could only be one pending request for the settings DB, but attachment 715842 [details] [diff] [review] regressed this.

We now consistently see two getAll() requests, which is going to contribute the problem in bug 842215 and regress memory usage as well.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Fix regression

Comment 2

[Evelyn Hung]

Comment on attachment 716711 [details] [diff] [review]
Fix regression

I tried the same way to prevent multiple query on bug 842215, and verified it works.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

CC'ing offender :-/

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(You'll want to grab this one, if you haven't already.)

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #3)
> CC'ing offender :-/

BTW, no worries; the invariant maintained by the original code was fairly subtle (sorry! my fault), and we don't have any performance tests that would have caught regressions from violating it.

Comment 6

[Alex Keybl [:akeybl]]

Can this land in preparation for uplift?

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://github.com/mozilla-b2g/gaia/commit/949a0eed6cb28bfcd9a943effef96e356ca83ebf

Comment 8

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(There was a small typo in the commit.  [sic])

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train@3c9f82b
v1.0.1@05457b4

Comment 10

[Darren]

Cannot verify, need steps to blackbox test this issue.