Closed Bug 843780 Opened 11 years ago Closed 11 years ago

[sms] Fix desktop mock

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::SMS
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g18 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
b2g18 --- fixed

People

(Reporter: jugglinmike, Assigned: jugglinmike)

References

Details

Attachments

(1 file, 2 obsolete files)

Fix desktop mocking
6.19 KB, patch
borjasalguero
: review+
lsblakk
: approval-gaia-v1+
Details | Diff | Splinter Review 
The mocked SMS functionality for desktop development is no longer working. The JavaScript throws errors, and "sending" SMS's has no discernible effect on the application.
Blocks: 843776
Attached patch Fix desktop mocking (obsolete) — — Splinter Review 

        Attachment #716741 -
        Flags: review?(kgrandon)

    
    

    
  
Comment on attachment 716741 [details] [diff] [review]
Fix desktop mocking

Going to pass this one off to Borja to review - as he has done most of the implementation of this functionality.

        Attachment #716741 -
        Flags: review?(kgrandon) → review?(fbsc)

    
  
Assignee: nobody → mike

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Fix desktop mocking (obsolete)
        — 
          — Splinter Review
      

    


  
This addresses the issues raised by reviewer :rwaldron

        Attachment #716741 -
        Attachment is obsolete: true

        Attachment #716741 -
        Flags: review?(fbsc)

        Attachment #716792 -
        Flags: review?(fbsc)

    
    

    
  


  
Changes based on feedback from :rwaldron and :borjasalguero on GitHub:

https://github.com/mozilla-b2g/gaia/pull/8246

        Attachment #716792 -
        Attachment is obsolete: true

        Attachment #716792 -
        Flags: review?(fbsc)

    
  

        Attachment #717417 -
        Flags: review?(fbsc)

        Attachment #717417 -
        Flags: review?(fbsc) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 717417 [details] [diff] [review]
Fix desktop mocking

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Latest changes in Gaia
User impact if declined: More than user this it's a key point for MMS/SMS developers in order to get desktop testing working. More than useful for UI improvements and future Pull Requests.
Testing completed: 
Risk to taking this patch (and alternatives if risky): None. There is no risk and it's needed for dev-team.
String or UUID changes made by this patch:

        Attachment #717417 -
        Flags: approval-gaia-v1?

        Attachment #717417 -
        Flags: approval-gaia-v1? → approval-gaia-v1+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: