843794 - If GhostRank is enabled, all private browsing links are available in about:cache?device=disk after private browsing is exited.

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[mike]

User Agent: Mozilla/5.0 (Windows NT 6.0; rv:19.0) Gecko/20100101 Firefox/19.0
Build ID: 20130215130331

Steps to reproduce:

Not sure if this is bug or a concern, but private browsing users might not know about having giving-feedback enabled (by default?). Are there any other popular addons that can send feedback ? ABP ?

I notice that if GhostRank is enabled, all private browsing links are "available" in about:cache?device=disk after private browsing is exited.

Basically all auto feedback in all addons has to be turned off.


Actual results:

all private browsing links are available in about:cache?device=disk after private browsing is exited.


Expected results:

no private browsing links available in about:cache?device=disk after private browsing is exited.

Comment 1

[(no longer active)]

Jorge, can we contact the author of this add-on please?  Thanks!

Comment 2

[Rodrigo Andrade]

I could not reproduce this error. Besides that, I suppose the Ghostery source code verifies whether the actual tab is private before saving the URLs, as the following piece of code demonstrates:

if (conf.ghostrank && !(SDK.pb && SDK.pb.isPrivate(tab))) {
 ghostrank.appendAFStat(tab_id, data.src, data.af, {
  tab_url: tab_url,
  bug_id: bug_id,
  latency: -1,
  af: data.af,
  block: block,
 });
}

Comment 3

[Luke Crouch [:groovecoder]]

I was not able to reproduce this in latest Firefox 59 with Ghostery add-on installed with GhostRank enabled. I also checked the latest source code of the Ghostery add-on and it checks for isChannelPrivate (via tab.incognito) before sending data.

I'm closing this one as resolved:fixed but adding a note for our PBM test plan to check about:cache before and after PBM sessions.