843799 - windows.open should use require('window/utils').open and not openDialog

Status: RESOLVED INCOMPLETE

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

windows.open should use require('window/utils').open and not require('window/utils').openDialog so that it no longer depends on a open window to make a new window.

Comment 1

[Sunny [:darkowlzz]]

Hi,

I would like to work on this bug.

I have made changes to lib/sdk/windows/loader.js  Line43,
changed |openDialog| to |open| but I am not sure if this is enough. |open| requires a uri and options. If the uri isn't passed, |open| opens browser.xul implicitly. |openDialog| in this line file passes |private| also, which is not handled anywhere in |open|. 
Will changing |openDialog| to |open|, with change in |require| line, serve the requirements?
Also how should the test be written for this? I don't see anything helpful in test-window-loader.js.

Please see if I am on the right track and help me out.

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

I'm taking the [good first bug] off of this bug.  While working on the sidebar tests I noticed that opening a window with { features: { toolbars: true, chrome: true, .. } } and some other variations here, I could not get a browser window with a working sidebar.. so I worked around that (see the sidebar tests).. and that makes me think that this bug would actually be hard, and require a lot of testing.

Comment 3

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1399562