Closed Bug 843800 Opened 7 years ago Closed 7 years ago

PopupNotifications needs to know about location changes in background tabs

Categories

(SeaMonkey :: General, defect)

defect
Not set

Tracking

(seamonkey2.18 fixed, seamonkey2.19 fixed)

RESOLVED FIXED
seamonkey2.19
Tracking Status
seamonkey2.18 --- fixed
seamonkey2.19 --- fixed

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file)

Instead of using nsBrowserStatusHandler.js, we now need to notify PopupNotifications from each <notificationbox type="popup">.
Attached patch Possible patchSplinter Review
Unfortunately removing popupNotifications from nsBrowserStatusHandler.js means that I don't have anywhere convenient to remember whether I created the notifications lazily or not, so this version always creates the notifications eagerly, since they're going to be notified in the next location change anyway.

XBL isn't good at calling inherited methods so I moved as much as I could of the onLocationChange logic out to a separate method and duplicated the rest.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #716756 - Flags: review?(iann_bugzilla)
From Bug 842412:

neil@parkwaycc.co.uk      2013-02-18 16:36:25 PST
> As per bug 839445 we need to notify the PopupNotifications object when any relevant
> onLocationChange fires, not just for the current tab.

[reply] [-] Comment 1 Philip Chee 2013-02-22 11:33:58 PST
> Neil pushed a wallpaper bustage fix (fallout from bug 839445).
> http://hg.mozilla.org/comm-central/rev/26093ce6e30c
Duplicate of this bug: 842412
Attachment #716756 - Flags: review?(iann_bugzilla) → review+
Pushed comm-central changeset 97ec0b9859f1.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.19
Comment on attachment 716756 [details] [diff] [review]
Possible patch

[Approval Request Comment]
Regression caused by (bug #): 839445
User impact if declined: PopupNotifications in background tabs linger
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): 
String changes made by this patch: None
Attachment #716756 - Flags: approval-comm-aurora?
Comment on attachment 716756 [details] [diff] [review]
Possible patch

a=me
Attachment #716756 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.