843811 - BaselineCompiler: Land tests for various assertions/crashes

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

evalcx("\
    try {\
        throw\"\"\
    } catch (\
        x if (function(){\
            x\
        })()\
    ) {}\
", newGlobal(""))

asserts js debug shell on ionmonkey changeset 2445c6378f36 without any CLI arguments at Assertion failure: str->zone() == cx->runtime->atomsCompartment->zone(),

eval("\
    try {\
        throw\"\"\
    } catch (\
        x if (function(){\
            x\
        })()\
    ) {}\
")

asserts js debug shell at Assertion failure: size_t(dst - src) >= nelem,

Function("\
    try {\
        throw\"\"\
    } catch (\
        x if (function(){\
            x\
        })()\
    ) {}\
")()

crashes js debug shell at JS::LossyTwoByteCharsToNewLatin1CharsZ

These were likely caused by:

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   121320:d0639bd4b896
user:        Brian Hackett
date:        Thu Feb 07 12:10:50 2013 -0700
summary:     Bug 838820 - Compile NAME and ALIASEDVAR related opcodes, r=djvj.

Later, these were all fixed by:

autoBisect shows this is probably related to the following changeset:

The first good revision is:
changeset:   122610:de894e57ecb2
user:        Jan de Mooij
date:        Thu Feb 21 13:33:39 2013 +0100
summary:     Bug 843429 - Fix SETALIASEDVAR clobbering stack values. r=bhackett

but I'd like to have them added to the testsuite.

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Thanks to Terrence for helping me out here. Tests are coming right up.

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: patch v1

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

I ran:

python -u jit_test.py --no-slow --tbpl -t 1200 <js shell from ionmonkey tip> bug843811-1.js bug843811-2.js bug843811-3.js

to ensure that they did not crash or assert.

Comment 4

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Please feel free to land this after the review, if it looks good.

Comment 5

[Jan de Mooij [:jandem]]

Comment on attachment 716775 [details] [diff] [review]
patch v1

Review of attachment 716775 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome!

Comment 6

[Jan de Mooij [:jandem]]

(In reply to Gary Kwong [:gkw] from comment #4)
> Please feel free to land this after the review, if it looks good.

Pushed:

https://hg.mozilla.org/projects/ionmonkey/rev/836ed183bb5f

Comment 7

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Tests were landed. -> VERIFIED and in-testsuite+.