Closed
Bug 843830
Opened 11 years ago
Closed 11 years ago
QCMS enums "repeated" in gfxPlatform.cpp
Categories
(Core :: Graphics: Color Management, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: milan, Assigned: milan)
Details
Attachments
(1 file)
3.02 KB,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
qcms.h defines QCMS_INTENT_ enums, and gfxPlatform.cpp defines INTENT_MIN to 0 and INTENT_MAX to 3, and defines its own INTENT_DEFAULT. These values should be based on what the qcms enums are, and should probably live where the enum is defined.
Assignee | ||
Comment 1•11 years ago
|
||
Trivial issue, but could be trouble if the enum changes and we don't know about the place in the source that "knows" what the enum range is. So, move it all in one place.
Attachment #716801 -
Flags: review?(bgirard)
Updated•11 years ago
|
Attachment #716801 -
Flags: review?(bgirard) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2aec67f21b73
Keywords: checkin-needed
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2aec67f21b73
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•