Closed Bug 843830 Opened 8 years ago Closed 8 years ago

QCMS enums "repeated" in gfxPlatform.cpp

Categories

(Core :: GFX: Color Management, defect)

x86
All
defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: milan, Assigned: milan)

Details

Attachments

(1 file)

qcms.h defines QCMS_INTENT_ enums, and gfxPlatform.cpp defines INTENT_MIN to 0 and INTENT_MAX to 3, and defines its own INTENT_DEFAULT.  These values should be based on what the qcms enums are, and should probably live where the enum is defined.
Trivial issue, but could be trouble if the enum changes and we don't know about the place in the source that "knows" what the enum range is.  So, move it all in one place.
Attachment #716801 - Flags: review?(bgirard)
Attachment #716801 - Flags: review?(bgirard) → review+
https://hg.mozilla.org/mozilla-central/rev/2aec67f21b73
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.