Closed
Bug 84401
Opened 23 years ago
Closed 23 years ago
PrefEnumCallback leaks strings
Categories
(Core :: Internationalization, defect, P2)
Tracking
()
VERIFIED
FIXED
mozilla0.9.2
People
(Reporter: dbaron, Assigned: ftang)
References
Details
(Keywords: intl, memory-leak, top-memory-leak, Whiteboard: [PDT+]wait for tree open to check in .)
Attachments
(2 files)
|
1.32 KB,
patch
|
Details | Diff | Splinter Review | |
|
1.42 KB,
patch
|
Details | Diff | Splinter Review |
The changes made by bstell in revision 1.140 of nsFontMetricsGTK.cpp for bug 67732 and bug 69139 cause PrefEnumCallback to leak the string |value| whenever |name.Equals(value)|. This is causing rather significant leaks.
|
Reporter | |
Comment 1•23 years ago
|
||
Oops, meant to assign to bstell.
|
||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.2
|
|
||
Updated•23 years ago
|
Priority: -- → P1
|
Assignee | |
Comment 2•23 years ago
|
||
I believe dbaron mean that the value is not free from block start from
3304 if ((value) && (!name.Equals(value))) {
we should add a
if(value) {
nsMemory::Free(value);
value = nsnull;
}
right before return.
|
|
Assignee | |
Comment 3•23 years ago
|
||
bstell is overload. mark it moz0.9.2 P2 and move it to ftang
Priority: P1 → P2
|
|
Assignee | |
Comment 4•23 years ago
|
||
bstell is overload. mark it moz0.9.2 P2 and move it to ftang
Assignee: bstell → ftang
Status: ASSIGNED → NEW
|
|
Assignee | |
Comment 5•23 years ago
|
||
pdt+ base on 6/11 pdt meeting.
|
|
Assignee | |
Updated•23 years ago
|
Whiteboard: [PDT+]
|
|
Assignee | |
Comment 6•23 years ago
|
||
|
|
Assignee | |
Comment 7•23 years ago
|
||
dbaron@fas.harvard.edu (David Baron) can you review the patch?
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 8•23 years ago
|
||
That patch compares |name| to |value| after setting |value| to |nsnull|. It would be easier to just use nsXPIDLCString (and better proofed against future changes).
|
|
||
Comment 9•23 years ago
|
||
|
|
Reporter | |
Comment 10•23 years ago
|
||
r=dbaron, although you should probably also remove the explicit nulling of |value| that was right after the two calls to |nsMemory::Free| that you removed.
|
||
Comment 11•23 years ago
|
||
sr=kin@netscape.com with the change that dbaron suggested.
|
|
Assignee | |
Updated•23 years ago
|
Whiteboard: [PDT+] → [PDT+]r=dbaron sr=kin need a=
|
||
Comment 12•23 years ago
|
||
*** Bug 83748 has been marked as a duplicate of this bug. ***
|
|
||
Comment 13•23 years ago
|
||
ftang, what's up? can we get this checked in?
|
|
Assignee | |
Comment 14•23 years ago
|
||
I am waiting for a=
|
|
Reporter | |
Comment 15•23 years ago
|
||
a=dbaron for trunk checkin (on behalf of drivers), assuming you make the change requested above. In general, though, if you want a=, please email drivers@mozilla.org asking for it.
|
|
Assignee | |
Updated•23 years ago
|
Whiteboard: [PDT+]r=dbaron sr=kin need a= → [PDT+]wait for tree open to check in .
|
|
Assignee | |
Comment 16•23 years ago
|
||
fixed and check in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
||
Comment 17•23 years ago
|
||
Changing QA contact to ftang@netscape.com for now. Frank, can you verify this within development or provide IQA with a test case? Thanks.
QA Contact: andreasb → ftang
You need to log in
before you can comment on or make changes to this bug.
Description
•