Move webapprt locale files

RESOLVED FIXED in Firefox 23

Status

Firefox Graveyard
Webapp Runtime
RESOLVED FIXED
4 years ago
a year ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 23
Dependency tree / graph

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
In bug 762864, the webapprt locale files were (rightfully) moved under webapprt/chrome in the firefox directory. To avoid l10n problems, that was hooked in a hackish way in browser/locales/jar.mn, while the locale files themselves were kept under browser/locales/en-US/webapprt in the source tree.

Now that basically everything related to webapprt has moved to toolkit, bug 762833 requires the webapp runtime to be built as part of the platform instead of browser. Which means the locales also need to be built from toolkit instead of browser. It is thus time to move the locale files where they belong: under webapprt/locales.
(Assignee)

Comment 1

4 years ago
Created attachment 723462 [details] [diff] [review]
Move webapprt locale files
Attachment #723462 - Flags: review?(l10n)

Comment 2

4 years ago
Comment on attachment 723462 [details] [diff] [review]
Move webapprt locale files

Review of attachment 723462 [details] [diff] [review]:
-----------------------------------------------------------------

You'll need to patch browser/locales/filter.py, too, like

  if mod not in ("netwerk", "dom", "toolkit", "security/manager",
                 "browser", "browser/metro", "extensions/reporter",
                 "extensions/spellcheck",
                 "other-licenses/branding/firefox",
                 "browser/branding/official",
                 "webapprt",
                 "services/sync"):
    return False

Not really picky about where you add webapprt here.

Apart from this, this looks good.

The PPL_LOCALE_ARGS tickled my senses, but that seems to be the same thing as in the general windows installer. I wonder if we should refactor that as follow-up, and/or unify with what jarmaker does these days.
Attachment #723462 - Flags: review?(l10n) → review-
(Assignee)

Comment 3

4 years ago
Created attachment 732851 [details] [diff] [review]
Move webapprt locale files
Attachment #732851 - Flags: review?(l10n)
(Assignee)

Updated

4 years ago
Attachment #723462 - Attachment is obsolete: true

Updated

4 years ago
Attachment #732851 - Flags: review?(l10n) → review+
(Assignee)

Comment 4

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/214cafc09b49

Updated

4 years ago
Blocks: 735571
https://hg.mozilla.org/mozilla-central/rev/214cafc09b49
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.