844084 - Add a full-window option for video

Status: RESOLVED WONTFIX

(Toolkit :: Video/Audio Controls, defect)

Description

[Anthony Ricaud (:rik)]

Putting a video fullscreen comes with some limitations (at least on the mac). One of them is that you can't use other tabs from the same window.

A full window option would be nice. Similar to what http://sublimevideo.net/ does when you do Opt-Click on the fullscreen arrow.

Comment 1

[Anthony Ricaud (:rik)]

Attachment: Work in progress

Here is my first take on it. It works correctly on standalone video documents but the problem is that it adds a class on regular webpages. Is there a way to only execute this code on standalone video documents?

Comment 2

[Paul Adenot (:padenot)]

Comment on attachment 717634 [details] [diff] [review]
Work in progress

I believe this would do the job, but you certainly don't want me to provide useful feedback on a front-end patch :-)

Forwarding the feedback to Jared.

Comment 3

[Anthony Ricaud (:rik)]

Attachment: First working patch

So Paul gave me the document.mozSyntheticDocument trick to only add the class for standalone videos.

Jared: Do you think this is the proper code approach for such a feature? Should we involve someone from UX?

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 717868 [details] [diff] [review]
First working patch

Review of attachment 717868 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/widgets/videocontrols.xml
@@ +1020,5 @@
> +                    if (this.isVideoInFullScreen()) {
> +                        document.mozCancelFullScreen();
> +                        return;
> +                    }
> +                    if (e.altKey && document.mozSyntheticDocument) {

This would also need to check to make sure that top == window.

Using ALT to choose full-window vs full-screen isn't going to be discoverable enough. An approach for this that may be suitable would be to have a full-window button that only appears if the controls are wide enough to leave room for it.

Bug 780427 proposes to use a similar show-only-when-possible button to the video controls.

Comment 5

[Anthony Ricaud (:rik)]

What about showing a "full-window" icon when we hover the "full-screen" icon, in the same fashion as the volume slider when we hover the volume icon ?

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Anthony Ricaud (:rik) from comment #5)
> What about showing a "full-window" icon when we hover the "full-screen"
> icon, in the same fashion as the volume slider when we hover the volume icon?

Hovering volume indicators to see a volume slider is pretty commonplace among web video playback controls, but I don't think this type of interaction for full-window would be expected by users.

Comment 7

[Anthony Ricaud (:rik)]

True. But I don't see this as an issue. When you're about to go full-screen, you'll discover another option.

Whatever we choose, it seems we now need a new icon for this feature. How should we request it?

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

You can request an icon and interaction feedback from Stephen.

Comment 9

[Chris Pearce [:cpearce (Not reading bugmail)]]

Making a video full-window seems like it would be less frequently used than making a video fullscreen. Why don't we put the full-window option on the right-click context menu? Then we don't need to add yet another button to the video controls.

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

We could also just leave this for an add-on to implement. I now think that an add-on would probably be the better route.

Comment 11

[Anthony Ricaud (:rik)]

So should I try a patch with full-window in context menu or should we close this bug?

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

I'd vote for closing this bug and writing an add-on to fulfill the needs here.