84410 - downloading file with unknown size reports NaN% complete, negative time left and no progress bar

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[:glob ✱]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9+) Gecko/20010602
BuildID:    2001060220

downloading a file from a location that doesn't report the correct size produces
a few odd things with the progress dialog.

the status is reported as:  ###K of 0K bytes
i think that is the size isn't know, the "of 0K bytes" should not be displayed.

also, the process bar is always empty, with the percentage always displayed as
NaN%.  again, i think that if you can't determine the file size, you shouldn't
display the process bar.


Reproducible: Always
Steps to Reproduce:
you'll get this if you're downloading a file that is the output of a cgi.

there's 5 meg waiting for you at
  http://glob.com.au/mozilla/download.cgi?5

Comment 1

[Oliver Klee]

Related to bug 70859?

Comment 2

[Oliver Klee]

WFM. With 2001060820 Win2k, I'm seeing:

Status:    ### of ??K bytes (at ##.##K bytes/sec)

... and a spinning progress bar.
Could you retry with a new build?

Comment 3

[:glob ✱]

just tried with 2001060920 and i'm still seeing the problem.

i've got a screenshot of it at http://glob.com.au/mozilla/
(sorry - i don't know how to attach it to this bug)

also notice the time left counter is 00:0-14 in this screenshot (ie it's a
negative time).

Comment 4

[:glob ✱]

Attachment: screenshot of nan progress

Comment 5

[sairuh (rarely reading bugmail)]

->bill?

i see this using branch bits on linux [2001.06.07.13] and mac [2001.06.07.11];
also occurs with both themes. will attach screenshots.

Comment 6

[sairuh (rarely reading bugmail)]

bumping up to normal...doesn't seem trivial, imho :).

Comment 7

[sairuh (rarely reading bugmail)]

Attachment: linux modern, showing negative value and no progress painting

Comment 8

[sairuh (rarely reading bugmail)]

Attachment: mac classic shot, showing negative time and no progress painting

Comment 9

[Aleksey Nogin]

*** Bug 82702 has been marked as a duplicate of this bug. ***

Comment 10

[Paul Chen]

nav triage team:

Need to fix this eventually, but won't get around to it before mozilla1.0.
Marking nsbeta1+, p3, and mozilla1.0

Comment 11

[Ben Guthrie]

since I get this on http://ftp.mozilla.org/pub/mozilla/nightly/latest/
I don't think it's restricted to files of unknown size.  The size is 
known & right there on the page  

Comment 12

[sairuh (rarely reading bugmail)]

->mscott or blake...not sure if either of you have cycles for this one [true, it
has been marked moz1.0 --couldn't hurt to ask].

Comment 13

[Boris Zbarsky [:bzbarsky]]

*** Bug 87852 has been marked as a duplicate of this bug. ***

Comment 14

[Boris Zbarsky [:bzbarsky]]

*** Bug 87785 has been marked as a duplicate of this bug. ***

Comment 15

[robbe]

Ben: I can't reproduce on
http://ftp.mozilla.org/pub/mozilla/nightly/latest/mozilla-win32-installer-sea.exe
(with 0.9.1)

Which version are you seeing this -- maybe a regression?

Also be sure that no proxies doing filtering are in-between.

Comment 16

[Ben Guthrie]

Robbe,

I only see this problem when DLing via proxy.

at home via dialup generic ISP, the saving file statistics are AOK using the 
very same build I used at work for my last test.  home is 98 vs NT at work, 
direct connection vs firewall/proxy


I think I've been seeing this through the proxy for at least a week.  I have an 
older screen capture of the saving file box at work, I'll check the create date 
on that as soon as I get in

Ben

Comment 17

[Ben Guthrie]

Robbe,

I show this as early as 6/18.  I dl the latest at least once or twice a day & my 
time stamp is 11:51 EDT, so I was probably using a build from the day before.

bug 87852 which is a dupe of this one was my report & has more details specific 
to my case

Ben

Comment 18

[Skewer]

I'm seeing this in 2001070204 Win98.

Comment 19

[Skewer]

Attachment: Incorrect display in download window

Comment 20

[Skewer]

Attachment: Demonstration of expected behavior

Comment 21

[Skewer]

Just created bug 89113 for the proxy problem.

Comment 22

[Scott MacGregor]

Attachment: the fix

Comment 23

[Scott MacGregor]

I've attached the fix. Please note the one line DTD change so we can actually
show the word "Unknown" in the time left field. If we try to get this into rtm,
we'll have to get localization to approve this dtd change. 

nominating for the branch.

Comment 24

[Skewer]

*** Bug 87327 has been marked as a duplicate of this bug. ***

Comment 25

[Blake Ross]

sr=blake

Comment 26

[Scott MacGregor]

this very low risk fix has been checked into the trunk. Adding the vtrunk
keyword. I'm hoping this can make it into a nsbranch+ state due to the low risk. 

Comment 27

[sairuh (rarely reading bugmail)]

tested using a 21:23 debug trunk build on linux: definitely an improvement, but
the "0K bytes" in the Status is still there while download is in progress...any
way to easily change that string to "Unknown" as well?

however, when download is finished, the Status does redraw to display the total
elapsed time.

screenshots coming up.

Comment 28

[sairuh (rarely reading bugmail)]

Attachment: download progress dialog when in progress, showing "0K bytes" in Status

Comment 29

[sairuh (rarely reading bugmail)]

Attachment: download progress dialog, went download is complete

Comment 30

[sairuh (rarely reading bugmail)]

erm, i meant: s/went/when in the attachment comment.

Comment 31

[Skewer]

*** Bug 87327 has been marked as a duplicate of this bug. ***

Comment 32

[sairuh (rarely reading bugmail)]

verified fixed using 2001.07.05.0x-trunk comm bits on mac, linux and winNT
--except for the "0K bytes" issue noted above. [let me know whether we're going
to stay with that for now.]

Comment 33

[scottputterman]

When the branch is open, please check this into it today after getting
permission to add the new string.

Comment 34

[Scott MacGregor]

fixed on the branch.

Comment 35

[Skewer]

Attachment: "of 0K bytes" display in 2001070604 Win98

Comment 36

[sairuh (rarely reading bugmail)]

removing vtrunk since i had already vrfy'd it there on 2001-07-05 13:51.
verified fixed on the branch using the following comm branch builds:

linux 2001.07.09.04
winnt 2001.07.09.05
mac 2001.07.09.03

filed bug 90074 to fix the "OK bytes" Status string while download is in
progress.

Comment 37

[Ben Guthrie]

do we need to file a seperate bug to address the issue of why it is unknown when
through a proxy, but known otherwise?

DLing the latest Mozilla is a classic example.  at home via dailup I get a %
completion & the size is known.  at work, via a proxy, the size is "unknown" 

Comment 38

[sairuh (rarely reading bugmail)]

ben, it'd prolly be best to file a separate bug on that in the Networking
component...

Comment 39

[basic]

ben see bug 89113 for the proxy problem

Comment 40

[Boris Zbarsky [:bzbarsky]]

*** Bug 90602 has been marked as a duplicate of this bug. ***

Comment 41

[Christopher Aillon (sabbatical, not receiving bugmail)]

*** Bug 92149 has been marked as a duplicate of this bug. ***