844102 - TBPL does not display errors that occurred during bug starring comment submission

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Ed Morley [:emorley]]

Starring bugs using a Vagrant TBPL instance currently fails to add a comment to the bug, even with the correct tbplbot credentials filled out in config.php

Similarly, in bug 802104 tbpl-dev wasn't able to submit bug comments, even though no failure message was displayed in the TBPL UI (the root cause there was out of sync credentials in config.php for tbplbot).

We should make submitBugzillaComment.php correctly return failure & then AddCommentUI.js::_postOneBug() handle them, displaying an error in the TBPL message bar (similar to failed retrigger requests).

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch v1

Ideally we'd split more of this handling out to somewhere central, but at least this gets us error messages for now :-)

[And in the case of bug 844103, revealed that we're hitting the die('Needs CURL!') when using Vagrant]

Comment 2

[Arpad Borsos [:Swatinem]]

Comment on attachment 717209 [details] [diff] [review]
Patch v1

Review of attachment 717209 [details] [diff] [review]:
-----------------------------------------------------------------

As long as the `complete` callback is still being fired this looks good.

Comment 3

[Ed Morley [:emorley]]

Yup, I've just checked and the complete still fires fine.

Thank you for the review :-)

https://hg.mozilla.org/webtools/tbpl/rev/c476a0079171

Comment 4

[Ed Morley [:emorley]]

In production :-)