Closed Bug 844133 Opened 7 years ago Closed 7 years ago

remove the MOZ_GRAPHITE configure option

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla22

People

(Reporter: jfkthame, Assigned: jfkthame)

Details

Attachments

(1 file)

When we landed the Graphite text-shaping library in bug 631479, we included a configure option that could be used to completely eliminate it from the build, in case we found it necessary to pull it for some reason. AFAIK, we've never had occasion to even consider using this switch. I think by this time, we can say that the code is stable and trusted enough that this option is unnecessary. (Note that we still have a runtime pref that controls whether the library is actually used or not. It's currently off by default, although bug 700023 proposes to change that.) Eliminating the configure-time option will allow us to remove a bunch of clutter from configure, makefile and source files.
Comment on attachment 717151 [details] [diff] [review]
eliminate the MOZ_GRAPHITE configure option

Review of attachment 717151 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/Makefile.in
@@ +343,5 @@
>  endif
>  
>  DEFINES += -DIMPL_THEBES -DHB_DONT_DEFINE_STDINT
>  DEFINES += -DMOZ_OTS_REPORT_ERRORS
> +DEFINES += -DGRAPHITE2_STATIC

You could clean these up into a single list while you're here.

::: gfx/thebes/gfxMacPlatformFontList.mm
@@ -268,5 @@
> -        // TODO: when we remove the MOZ_GRAPHITE conditional,
> -        // we can merge this into the preceding if().
> -        // Hence not (temporarily) indenting the code below
> -        // by an extra level, only to undo that next time we
> -        // touch it.

Nice forethought. :)
Attachment #717151 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/1861d261f88f
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.