844134 - attributes should be defined on Element and not Node

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Erik Arvidsson]

It makes no sense to expose attributes and hasAttributes on non Elements and DOM core updated the spec accordingly.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I've got a patch for attributes.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

I filed bug 849661 for hasAttributes.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 723255 [details] [diff] [review]
Patch v1

Review of attachment 723255 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the below fixed.

::: layout/inspector/src/inDOMView.cpp
@@ +1178,5 @@
>  {
>    NS_ENSURE_ARG(aNode);
>    // attribute nodes
>    if (mWhatToShow & nsIDOMNodeFilter::SHOW_ATTRIBUTE) {
> +    if (nsCOMPtr<nsIDOMElement> element = do_QueryInterface(aNode)) {

Are you sure this will work? The assignment operator for do_QI works weirdly in that do_QI doesn't actually return the result of the QI, it always returns a non-null object.

I'd move this outside out the if-statement and just do |if (element)| to be on the safe side. It's not causing any runtime or compile time cost.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/27a901ae549c

Comment 5

[Kohei Yoshino [:kohei]]

I've added this bug to the compatibility doc. Please correct the info if wrong.
https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_22

Also, please update the following doc:
https://developer.mozilla.org/en-US/docs/DOM/Node.attributes

Comment 6

[Jean-Yves Perrier [:teoli]]

Doc updated:
Node.attributes moved to Element.attributes https://developer.mozilla.org/en-US/docs/Web/API/Element.attributes
https://developer.mozilla.org/en-US/docs/Web/API/Node
https://developer.mozilla.org/en-US/docs/Web/API/Element
https://developer.mozilla.org/en-US/Firefox/Releases/22