844187 - icon.png and icon64.png from XPI aren't used in installing popover.

Status: RESOLVED INACTIVE

(Toolkit :: Add-ons Manager, defect)

Description

[Blake Winton (:bwinton) (:☕️)]

As shown in https://github.com/bwinton/whimsy/blob/master/package.json#L34 the values are in the package.json, but as shown in http://cl.ly/image/1r081w0g3e1u the icon is still the puzzle piece.

Mossop says "I think this is the problem http://hg.mozilla.org/mozilla-central/annotate/d014f356fd63/toolkit/mozapps/extensions/XPIProvider.jsm#l4530", which seems reasonable to me…  ;)

(You can check out the add-on at https://people.mozilla.com/~bwinton/whimsy/whimsy.xpi )

Thanks,
Blake.

Comment 1

[Dave Townsend [:mossop]]

I suspect things might be better now that we unlock packed XPIs but I'm not sure.

Comment 2

[Dave Townsend [:mossop]]

Note icon and icon64 from package.json translate to an icon.png and icon64.png in the root of the XPI.

Comment 3

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.