844188 - fix revision url for telemetry pings

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Nathan Froyd [:froydnj]]

Build folks noted problems in the fix for bug 832007 in bug 832007 comment 13 and bug 832007 comment 14.  Bug 832007 comment 15 also indicates that we would be better served with the makefile functions in:

http://dxr.mozilla.org/mozilla-central/config/makefiles/rcs.mk#l25

Also, looking at build logs indicates that m-c builds, at least, are getting strings like:

-DHISTOGRAMS_FILE_VERSION="http://hg.mozilla.org/mozilla-centralrev/e946347c031f"

which is bogus.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: use rcs.mk's functions for getting the source repo for telemetry revision ids

Verified that we now get:

-DHISTOGRAMS_FILE_VERSION="http://hg.mozilla.org/mozilla-central/rev/885cde564ff3"

as desired.

Comment 2

[Vladan Djeric (:vladan)]

Thanks for jumping on this Nathan :) 
Should we also add a function to rcs.mk that returns the repo's revision?

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 717215 [details] [diff] [review]
use rcs.mk's functions for getting the source repo for telemetry revision ids

Review of attachment 717215 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/Makefile.in
@@ +64,5 @@
>  ifdef MOZILLA_OFFICIAL
>  DEFINES += -DMOZILLA_OFFICIAL
>  endif
>  
> +MOZ_HISTOGRAMS_VERSION ?= $(call getSourceRepo)/rev/$(shell hg -R $(topsrcdir) parent --template="{node|short}\n" 2>/dev/null)

To mimic other places using this construct, you should use $(firstword $(shell ...)).

Comment 4

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/06b59fc0a662

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/06b59fc0a662