Closed
Bug 844295
Opened 11 years ago
Closed 11 years ago
Unexpose the removeStream function on the Peer Connection object temporarily
Categories
(Core :: WebRTC, defect, P3)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: jsmith, Assigned: snandaku)
Details
(Whiteboard: [webrtc][blocking-webrtc+][qa-])
Attachments
(1 file)
|
835 bytes,
patch
|
abr
:
review+
jesup
:
review+
|
Details | Diff | Splinter Review |
The removeStream function right now doesn't have much use without renegotiation existing and fixing associated bugs like bug 842455. So exposing this function publicly right now really introduces a developer footgun - they are using a function that doesn't have much use and known problems with it. We might want to turn the API off temporarily until we solve the underlying issues.
|
||
Comment 1•11 years ago
|
||
Any objections to a small patch to do this for now, if it's useless/unsafe?
Assignee: nobody → adam
Whiteboard: [webrtc][blocking-webrtc?]
|
||
Comment 2•11 years ago
|
||
I would prefer it it were a stub, since that way it doesn't cause an exception
|
||
Updated•11 years ago
|
Whiteboard: [webrtc][blocking-webrtc?] → [webrtc][blocking-webrtc+]
|
||
Updated•11 years ago
|
Priority: -- → P3
Added one line fix to say RemoveStream is "NOT IMPLEMENTED" in PeerConnection.js.
Attachment #729985 -
Flags: review?(adam)
Attachment #729985 -
Flags: review?(rjesup)
|
Reporter | |
Updated•11 years ago
|
Whiteboard: [webrtc][blocking-webrtc+] → [webrtc][blocking-webrtc-]
|
|
Reporter | |
Updated•11 years ago
|
Whiteboard: [webrtc][blocking-webrtc-] → [webrtc][blocking-webrtc+]
|
|
||
Updated•11 years ago
|
Attachment #729985 -
Flags: review?(rjesup) → review+
Attachment #729985 -
Flags: checkin?(rjesup)
|
|
||
Updated•11 years ago
|
Attachment #729985 -
Flags: review?(adam) → review+
|
||
Updated•11 years ago
|
Attachment #729985 -
Flags: checkin?(rjesup)
|
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/214782bec2a6
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
|
|
Reporter | |
Updated•11 years ago
|
Whiteboard: [webrtc][blocking-webrtc+] → [webrtc][blocking-webrtc+][qa-]
|
|
Reporter | |
Updated•11 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•