Closed Bug 84432 Opened 23 years ago Closed 23 years ago

"Prefill form" option disabled/missing from menus when inside a frame

Categories

(Toolkit :: Form Manager, defect, P2)

Product:
Toolkit
Component:
Form Manager
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: bugzilla, Unassigned)

References

(
URL
)

Details

Attachments

(3 files)

HTML Testcase - File A
84 bytes, text/html
Details
HTML Testcase - File B
103 bytes, text/html
Details
Patch to recursively process frames
4.39 KB, patch
Details | Diff | Splinter Review 
If you go to:
http://www.fakta.dk/index2a_new.asp?id=7
and right click the "Prefill form" is missing from the context menu

build 20010604
Problem here is that the form is inside a frame and my walking of the dom does 
not go inside of frames.  For the same reason, the prefill-form and save-form 
entries in the edit menu will always be disabled, even when there is something 
to save and/or prefill.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.2
Does this happen for all forms in frames? I'm inclined to move this to m0.9.3 if
its not a regression.
Keywords: nsbeta1
I haven't tested it with *all* forms, but I'd venture a guess that it is so.

No, it's not a regression.  But it does mean that there is no way to ever use 
wallet on forms in frames -- either to capture or to prefill.
perhaps there are two different states here.
on http://www.fakta.dk/index2a_new.asp?id=7 I dont even see the Prefill Form 
menuitems, while on other frame sites the Prefill form is just disabled.
The fact that you see it disabled just means that there is no saved data that 
can be prefilled on this form.  If you fill in something and save it, then 
you'll see the prefill entry become enabled.
nav triage team:

Not a stop ship bug, marking p2 and mozilla0.9.3
Priority: -- → P2
Target Milestone: mozilla0.9.2 → mozilla0.9.3
nav triage team:

Forgot to mark nsbeta1+
Keywords: nsbeta1 → nsbeta1+
nav triage team:

Nav triage team feels adding support for frames is too big of a risk for 
mozilla0.9.3. Marking mozilla1.0
Target Milestone: mozilla0.9.3 → mozilla1.0
*** Bug 91255 has been marked as a duplicate of this bug. ***
Target Milestone: mozilla1.0 → mozilla0.9.4
Updating summary to reflect fact that this is a general menu problem and not 
restricted to context menu.
Summary: "Prefill form" option missing from context menu → "Prefill form" option disabled/missing from menus
Another test case is:
http://www.filmland.dk/CANDYCLUBFILM/CANDYFILM/Ekon2/ekon2.htm

dont even ask how I found that one...:)

The site is not in frames or anything. Just a plain html page, but not Prefill
form context menu.
Gemal, your latest testcase works fine for me -- all three of the form-manager 
items appear in the context menu and are also not disabled in the edit menu.  
Maybe you were preoccupied looking at other things on that website to notice the 
menus. ;-)

The examples that I have seen which demonstrate this bug all use frames.
Something weird is going on here. Please help me out. I have a plain html page 
ala:
<html>
<body>
<form>
<select>
<option>1</option>
</select>
<input type="text" name="navn">
</form>
</body>
</html>

When rightclicking in the textinput field using 2001073003 on Win2k I get *NO* 
prefill menuitem and the menuitems in Edit is greyed out.

But if I have:
<html>
<body>
<form>
<input type="text" name="navn">
</form>
</body>
</html>

that where the select is deleted the Prefill context items and Edit menuitems 
appears. 110% reproducable...
Gemal, I'm unable to reproduce the problem that you just described.  With either 
of your two forms above, when I press the right mouse button I see the 
form-manager items and when I bring down the edit menu I see the items enabled.
Ok. Found a way to reproduce with a fresh profile:
I'm gonna attach two files. File A and File B.

1) Start mozilla with a new profile.
2) Select Tasks -> Privacy -> Password Manager -> Encrypt Data
3) Select Edit -> View Saved Data
4) Fill in a password
5) Load file A
6) Right click on the input form. Prefill context appears
7) Load file B
8) Right click on the input form. No Prefill context appears
Attached file HTML Testcase - File A — 

    
    

    
  

      
      
      
      

        Attached file
          
        HTML Testcase - File B
        — 
      

    


  

    
    

    
  
OK, I can reproduce the problem and I'll investigate.

This is really a separate bug from the frames problem.  Let's keep this bug for 
the frame case (I'll modify the summary line).  Please open this new problem in 
a separate report.
Summary: "Prefill form" option disabled/missing from menus → "Prefill form" option disabled/missing from menus when inside a frame

    
    

    
  
And I just created 92975.  So I'll close down one of them.

    
    

    
  
The URL given here:

   http://www.fakta.dk/index2a_new.asp?id=7

as well as the URL given in the dup bug 91255

   http://www.kamfung.net/

are both no longer valid test cases.  So I had to create my own test case of a 
form inside a frame.  Here is what I used:

  <html>
    <frameset rows=*,*>
      <frame name="form1" src="form1.htm">
      <frame name="noform" src="about:blank">
    </frameset>
    <noframes>
      <body> <P> </body>
    </notframes>
  </html>

along with the file form1.htm which consisted of

  <html>
    <body>
      <form>
        <input>
      </form>
    </body>
  </html>

Unfortunately I am unable to reproduce the problem with the above test case.  So 
I have no choice but to close this out as works-for-me.  If someone can come up 
with another testcase that demonstrates the problem, then please post it here 
and reopen.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → WORKSFORME

    
    

    
  
new url:
http://www.fakta.dk/index2a_new.asp?id=6
has frames and forms and no context menu
URL: http://www.fakta.dk/index2a_new.asp?id=7 → http://www.fakta.dk/index2a_new.asp?id=6
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---

    
    

    
  
OK, this is more involved than just a form in a frame.  It's a form in a frame 
in a frame.  Here is a simplified test case:

FILE 1: bug1.htm

  <html>
    <FRAMESET COLS='46,*'>
      <frame SRC="about:blank">
      <frame SRC="bug2.htm">
    </frameset>
    <noframes>
      <body>
      </body>
    </noframes>
  </html>

FILE 2: bug2.htm

  <html>
    <frameset COLS="197,*">
      <frame SRC="about:blank">
      <frame SRC="bug3.htm">
    </frameset>
    <noframes>
      <body>
      </body>
    </noframes>
  </html>

FILE 3: bug3.htm

  <html>
    <body>
      <form>
        <input name="name" value="">
      </form>
    </body>
  </html>

Status: REOPENED → ASSIGNED

    
    

    
  
cc'ing matt and blake for reviews

    
    

    
  
r=matt

    
    

    
  
rs=brendan@mozilla.org, sorry for the delay.

/be

    
    

    
  
Fix checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED

    
    

    
  
Verified fixed w2k build 2001-09-21-05-0.9.4
Verified fixed linux build 2001-09-24-04-0.9.4
Verified fixed mac OS X build 2001-09-24-04-0.9.4
Status: RESOLVED → VERIFIED
Assignee: morse → nobody
Product: Core → Toolkit
QA Contact: tpreston → form.manager
Target Milestone: mozilla0.9.4 → ---
Version: Trunk → unspecified

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: