844357 - Rename nsPresContext::Document to nsPresContext::GetDocument

Status: NEW

(Core :: Layout, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

The method may return null (after unlink), so it should have Get* prefix.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Does after unlink really count?  One shouldn't have access to the pres context after it's been unlinked, either.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

After unlink does count. That is at least how non-Get* methods work on dom side. Never ever return
null. (Well, there can be some phase during initialization of the object when the naming of the
method may lie.)
Since unlinking doesn't mean deletion, it shouldn't affect to the naming. The prescontext
has still access to itself. So, during deletion, one needs to null check Document().

Comment 3

[Cameron McCormack (:heycam)]

I just tried using mDocument from inside ~nsPresContext and failed.  I think at least a note in a comment where mDocument is defined would be good.  No opinion on renaming Document().