844412 - Create a theme directory for shared /toolkit theme resources

Status: RESOLVED WORKSFORME

(Toolkit :: Themes, defect)

Description

[Justin Dolske [:Dolske]]

Attachment: Patch v.0 (untested)

Bug 838244 seems like a pretty swell idea. Let's do that in /toolkit too.

Comment 1

[Justin Dolske [:Dolske]]

(This just moves the common in-content stuff for video controls and plugins, I'm sure there's more...)

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 717460 [details] [diff] [review]
Patch v.0 (untested)

>--- a/toolkit/themes/winstripe/mozapps/plugins/pluginProblem.css
>+++ b/toolkit/themes/shared/plugins/pluginProblem.css
>@@ -180,16 +180,25 @@ html|a {
> .closeIcon:hover {
>   background-position: -16px 0;
> }
> 
> .closeIcon:hover:active {
>   background-position: -32px 0;
> }
> 
>+%ifdef XP_MACOSX
>+@media (min-resolution: 2dppx) {
>+  .closeIcon {
>+    background-image: url("chrome://global/skin/icons/[e-mail]");
>+    background-size: auto 16px;
>+  }
>+}
>+%endif

As a basic principle, I'd prefer that instead of introducing ifdefs in shared/ we kept pinstripe/mozapps/plugins/pluginProblem.css, made it %include the shared pluginProblem.css and appended the @media (min-resolution: 2dppx) block. And if the differences add up, just keep the three files.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(In reply to Dão Gottwald [:dao] from comment #2)
> As a basic principle, I'd prefer that instead of introducing ifdefs in
> shared/ we kept pinstripe/mozapps/plugins/pluginProblem.css, made it
> %include the shared pluginProblem.css and appended the @media
> (min-resolution: 2dppx) block. And if the differences add up, just keep the
> three files.

Yeah, I agree.

Comment 4

[:Margaret Leibovic]

It looks to me like this happened in bug 888510... can we close this one?

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

videocontrols.css (and probably others) hasn't been moved to the shared directory, but I think we can close this one and open a new one for the files that still need to be moved.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Perhaps bug 1127234

Comment 7

[Tim Nguyen :ntim]

Can we close this ?