Give Edit buttons a hover state

RESOLVED FIXED in Thunderbird 22.0

Status

Thunderbird
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

17 Branch
Thunderbird 22.0
All
Mac OS X

Thunderbird Tracking Flags

(thunderbird20 fixed, thunderbird21 fixed, thunderbird-esr1720+ fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

4 years ago
+++ This bug was initially created as a clone of Bug #792021 +++

Comment on attachment 709778 [details] [diff] [review] [diff] [review]
patch v2

Okay, ui-r=me, but I'ld like you to file a couple of followup bugs, if you don't mind.
1) The cut/copy/paste icons don't have a hover state, and I think they should act more like the ▶ icon.
(Assignee)

Updated

4 years ago
No longer blocks: 789883
(Assignee)

Comment 1

4 years ago
Created attachment 717489 [details] [diff] [review]
proposed fix

Blake, I take you for reviews because you wanted this and I think it's the best you check this.

I've added white icons when in hover state. Additionally I removed the margins around the icons to make the edit menu only 18px tall (minimal icon height) and not 22px as before. the original menus are 17px tall.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #717489 - Flags: ui-review?(bwinton)
Attachment #717489 - Flags: review?(bwinton)
(Assignee)

Comment 2

4 years ago
Created attachment 717490 [details]
patch in action

Screenshot for easier review
Comment on attachment 717489 [details] [diff] [review]
proposed fix

While I appreciate that the background on hover is now the same height as the disclosure arrows, the cut/copy/paste icons seem to be pushing up against the edges a little now…  Is there any way you could make smaller icons for those?  I suspect the answer might be "No", so I'm going to say ui-r=me, even with the larger icons, so that this can move forward, but if you could make smaller icons, I think that would look nicer…

And the code seems fine, so r=me, as well.

Thanks,
Blake.
Attachment #717489 - Flags: ui-review?(bwinton)
Attachment #717489 - Flags: ui-review+
Attachment #717489 - Flags: review?(bwinton)
Attachment #717489 - Flags: review+
(Assignee)

Comment 4

4 years ago
Created attachment 717611 [details] [diff] [review]
proposed fix v2

My bad, I haven't realised the icons where already 16px (the glyphs are 14px with 1px around them) and drawn as 18px through the .toolbarbutton-icon rule. This patches fixes it to 16px with 1px margin. This lets this menu 18px tall but gives 2px space for the highlight background.

What do you think, is this a candidate to land on ESR because it fixes also the wrong icon dimensions?
Attachment #717489 - Attachment is obsolete: true
Attachment #717611 - Flags: ui-review?(bwinton)
Attachment #717611 - Flags: review?(bwinton)
(Assignee)

Comment 5

4 years ago
Created attachment 717613 [details]
patch v2 in action

I don't mark attachment 717490 [details] as obsolete for a better comparison of the space around the glyphs.
Comment on attachment 717611 [details] [diff] [review]
proposed fix v2

r=me, ui-r=me!

I'm not sure about landing it in the ESR…  Hopefully Standard8 or Irving will weigh in.

Thanks,
Blake.
Attachment #717611 - Flags: ui-review?(bwinton)
Attachment #717611 - Flags: ui-review+
Attachment #717611 - Flags: review?(bwinton)
Attachment #717611 - Flags: review+
Attachment #717611 - Flags: approval-comm-esr17?
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/3e82a183e342
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 22.0
Comment on attachment 717611 [details] [diff] [review]
proposed fix v2

[Triage Comment]
I think we possibly could take this on esr, but lets get some testing on aurora/beta first.
Attachment #717611 - Flags: approval-comm-beta+
Attachment #717611 - Flags: approval-comm-aurora+
https://hg.mozilla.org/releases/comm-aurora/rev/206010efb93f
status-thunderbird21: --- → fixed
https://hg.mozilla.org/releases/comm-beta/rev/36d033ee68cb
status-thunderbird20: --- → fixed
Attachment #717611 - Flags: approval-comm-esr17? → approval-comm-esr17+
https://hg.mozilla.org/releases/comm-esr17/rev/57e2f985b4bd
status-thunderbird-esr17: --- → fixed
tracking-thunderbird-esr17: --- → 20+
You need to log in before you can comment on or make changes to this bug.