844450 - Duplication in XBL keybindings

Status: RESOLVED WONTFIX

(Core :: XBL, defect)

Description

[[e-mail]]

I noticed that cmd_selectChar/LinePrevious/Next were defined identically in all the platform-specific bindings, when they could in fact be moved to browser-base.inc.

Looking into the bindings more closely, it seems that there is a lot of other duplication happening, the most obvious being that the editor and textAreas bindings are identical.

We can see this by breaking down the lists into four categories: a) intraline motion b) single line motion c) copy and select all d) cut, delete and paste.
inputFields uses b) c) d)
textAreas uses a) b) c) d)
browser uses a) b) c) *
editor uses a) b) c) d)
* Windows erroneously** includes some d) type bindings in its browser bindings.
** editing commands actually only operate in inputs, text areas and design mode and content editable documents, so we could actually reuse the same bindings here too!

Comment 1

[Boris Zbarsky [:bzbarsky]]

XBL is now disabled in Firefox (Bug 1583314) and is in the process of being removed from Gecko (Bug 1566221), so closing bugs requesting changes to its implementation as wontfix.