Last Comment Bug 844463 - packaging after build fails, if configure with --disable-updater
: packaging after build fails, if configure with --disable-updater
Product: Thunderbird
Classification: Client Software
Component: Build Config (show other bugs)
: Trunk
: All Linux
-- normal (vote)
: Thunderbird 22.0
Assigned To: Christoph Göhre
Depends on:
  Show dependency treegraph
Reported: 2013-02-23 08:35 PST by Christoph Göhre
Modified: 2013-03-07 16:02 PST (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

add more ifdefs in (1.75 KB, patch)
2013-02-23 08:44 PST, Christoph Göhre
standard8: review+
Details | Diff | Splinter Review

Description User image Christoph Göhre 2013-02-23 08:35:33 PST
If I build Thunderbird with '--disable-updater', the packaging at the end of the build process ends up with missing files. Here is the build log:

/BUILD/objdir-tb-release/_virtualenv/bin/python /BUILD/mozilla/toolkit/mozapps/installer/ -DMOZ_GLUE_IN_PROGRAM -DMOZ_THUNDERBIRD=1 -DOSTYPE=\"Linux3.2\" -DOSARCH=Linux -DNO_NSPR_10_SUPPORT -DAB_CD=en-US -DMOZ_APP_NAME=thunderbird -DPREF_DIR=defaults/pref -DMOZ_ENABLE_GNOME_COMPONENT=1 -DMOZ_GTK2=1 -DJAREXT= -DMOZ_CHILD_PROCESS_NAME=plugin-container -DDLL_PREFIX=lib -DBIN_SUFFIX= -DBINPATH=bin \
                --format omni \
                --removals /BUILD/mail/installer/ \
                --jarlogs /BUILD/objdir-tb-release/mail/installer/../../jarlog//en-US \
                --optimizejars \
                package-manifest ../../mozilla/dist ../../mozilla/dist/thunderbird \
                --non-resource defaults/messenger/mailViews.dat
Error: /BUILD/objdir-tb-release/mail/installer/package-manifest:29: Missing file(s): bin/update.locale
Error: /BUILD/objdir-tb-release/mail/installer/package-manifest:30: Missing file(s): bin/updater.ini
Error: /BUILD/objdir-tb-release/mail/installer/package-manifest:57: Missing file(s): bin/update-settings.ini
Error: /BUILD/objdir-tb-release/mail/installer/package-manifest:62: Missing file(s): bin/icons/*.png
Error: /BUILD/objdir-tb-release/mail/installer/package-manifest:586: Missing file(s): bin/updater

So I prepare a patch, which adds more ifdefs in mail/installer/ to get ride of this problem. In bug 736770 the problem was fixed for the Firefox browser.
Comment 1 User image Christoph Göhre 2013-02-23 08:44:14 PST
Created attachment 717521 [details] [diff] [review]
add more ifdefs in
Comment 2 User image Ryan VanderMeulen [:RyanVM] 2013-03-07 16:02:12 PST

Note You need to log in before you can comment on or make changes to this bug.