Improve wait for Preferences:Data in robocop tests

RESOLVED FIXED in Firefox 22

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gbrown, Assigned: gbrown)

Tracking

unspecified
Firefox 22
x86
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
In testAddonManager and testPasswordEncrypt, there are hacks for verifying that preferences have been set. The hacks can be removed now.
(Assignee)

Comment 1

5 years ago
Created attachment 717555 [details] [diff] [review]
remove pref hacks

Code stolen from testDistribution.
Attachment #717555 - Flags: review?(jmaher)
(Assignee)

Updated

5 years ago
Summary: Improve wait for Preferences:Data in robocop tests; r=jmaher → Improve wait for Preferences:Data in robocop tests
Comment on attachment 717555 [details] [diff] [review]
remove pref hacks

Review of attachment 717555 [details] [diff] [review]:
-----------------------------------------------------------------

I really don't understand this patch, but if it passes reliably on try server I don't have any objections.
Attachment #717555 - Flags: review?(jmaher) → review+
https://hg.mozilla.org/mozilla-central/rev/eea13ee399c5
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
You need to log in before you can comment on or make changes to this bug.