844590 - java.lang.NullPointerException: at org.mozilla.gecko.util.UiAsyncTask.execute(UiAsyncTask.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

It first showed up in 21.0a1/20130223 and is #2 top crasher in this build. The regression range is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=885cde564ff3&tochange=08a034e1d43a
It's likely caused by bug 842797.

java.lang.NullPointerException
	at org.mozilla.gecko.util.UiAsyncTask.execute(UiAsyncTask.java:45)
	at org.mozilla.gecko.AboutHomeContent.loadTopSitesThumbnails(AboutHomeContent.java:424)
	at org.mozilla.gecko.AboutHomeContent.access$200(AboutHomeContent.java:69)
	at org.mozilla.gecko.AboutHomeContent$8.run(AboutHomeContent.java:318)
	at android.os.Handler.handleCallback(Handler.java:605)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4424)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.util.UiAsyncTask.execute%28UiAsyncTask.java%29

Comment 1

[Scoobidiver (away)]

There are currently no crashes in 22.0a1/20130224.

Comment 2

[Brian Nicholson (:bnicholson)]

There's a few different stack traces in the crash reports. Bug 843851 fixed the most common one, but we should still deal with the rest.

Comment 3

[Brian Nicholson (:bnicholson)]

Attachment: Use Looper.getMainLooper() for UiAsyncTask. r=kats

Rather than having callers responsible for passing in a Handler (which is apparently error-prone), UiAsyncTask can get the UI thread on its own by using Looper.getMainLooper().

r=kats in IRC

Comment 4

[Brian Nicholson (:bnicholson)]

Attachment: Use Looper.getMainLooper() for UiAsyncTask, v2

Fixed synchronization and Javadocs

Comment 5

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/018649ef8ce6

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/018649ef8ce6