Implement Bug 842913 on comm-central (Rename winstripe->windows, pinstripe->osx, gnomestripe->linux)

RESOLVED FIXED in Thunderbird 22.0

Status

Thunderbird
Theme
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 22.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
I'm opening this bug to check, if we want follow m-c with renaming the themes directories. I've done a pre-check and this should be doable easily. This will affect /mail and /calendar. /suite uses classic and modern.

I think it makes sense to rename them to make it easier for contributors who comes from m-c to find the needed files. Until today we had already a difference in /mail where the Windows theme was named qute and I saw questions, where's the winstripe theme.

We should also wait until Bug 844597 is resolved to not change two times.
This sounds sane. It's a small thing, but makes it a lot easier for first time contributors.
I concur.
(Assignee)

Comment 3

5 years ago
Created attachment 720410 [details] [diff] [review]
rename it

Now as Bug 844597 is wontfix, here's the patch.

I'm asking mconley for review the mail stuff (in suite it's only two changes in comments) and Philipp for the calendar changes.

Philipp, I changed also the theme names in Sunbird. Is this okay?

In pinstripe I deleted the two files find.png and viewButtons.png. They are no more used and packed to the wrong positions in omni.ja (global and mozapps directly below classic/skin/classic instead of toolkit/skin/classic).

I pushed the patch to Try to check if it works: https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=097d9ca175db
I checked only the builds as it had in tests no reference to the old theme names.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #720410 - Flags: review?(philipp)
Attachment #720410 - Flags: review?(mconley)
Comment on attachment 720410 [details] [diff] [review]
rename it

Calendar part looks good, r=philipp
Attachment #720410 - Flags: review?(philipp) → review+
Comment on attachment 720410 [details] [diff] [review]
rename it

Review of attachment 720410 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the wait - hopefully, this hasn't bitrotted much / any. This looks OK to me - let's give this a shot and see what happens. :)
Attachment #720410 - Flags: review?(mconley) → review+
(Assignee)

Comment 6

5 years ago
Created attachment 728651 [details] [diff] [review]
patch for check-in

Patch was already bitrotted in osx/mail/chat.css
Attachment #720410 - Attachment is obsolete: true
Attachment #728651 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Updated

5 years ago
Whiteboard: Please check-in as last patch from checkin-needed patches
I checked this in with a couple of extra hg moves to pick up on files just landed:

https://hg.mozilla.org/comm-central/rev/0c65c10dc3aa
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: Please check-in as last patch from checkin-needed patches
Target Milestone: --- → Thunderbird 22.0
You need to log in before you can comment on or make changes to this bug.