844619 - Work - Expose crash reporting through prefs flyout

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Flyouts, defect, P2)

Description

[Jim Mathies [:jimm]]

This option is currently on by default (app.reportCrashes). For provacy reasons, we should expose this through the privacy section of the prefs flyout. It should be really easy to add, it's just a bool pref.

Comment 1

[Brian R. Bondy [:bbondy]]

I think we need a similar option for telemetry right?

Comment 2

[Jim Mathies [:jimm]]

(In reply to Brian R. Bondy [:bbondy] from comment #1)
> I think we need a similar option for telemetry right?

Yeah I think that fits. Fennec would notify on startup, but I remember turning that off for metrofx.

Comment 3

[Jim Mathies [:jimm]]

Attachment: prefs patch

Comment 4

[Jim Mathies [:jimm]]

Attachment: screen cap

Requesting ux review of the strings in the feedback section. Note there will be another option added here for telemetry.

Comment 5

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

Comment on attachment 718568 [details]
screen cap

I would suggest to be more specific about the data we will collect here.

1. I think "Feedback" is usually subjective information that comes from a user's point of view.
So it's not very accurate in this context. I am suggesting to use "Crash Reports" as the title. 


2. The current description is fine. But to be more specific about the data we are sending, and also consistent with other platforms, we could change to "Send Mozilla a report when a crash occurs" 


When we are ready to integrate with telemetry, we should add "Performance Data" in front of "Crash Reports", with description: "Help improve Nightly by sending Nightly's performance data to Mozilla"

Comment 6

[Marco Mucci [:MarcoM]]

Hey Asa, this work item is currently in triage.  Jim has selected a story that is dependant on it:  https://bugzilla.mozilla.org/show_bug.cgi?id=831972

Just need your review of this work item if it is to be included as part of 831972.

Comment 7

[Asa Dotzler [:asa]]

Though I wish this was all part of the Installer routine, since we don't have that yet and Installer's over in Desktop land, I suppose we need a pref for it. Sounds good to me.

Comment 8

[Robert Kaiser]

You can look at the descriptions we use on Firefox for this, they may be helpful. That said, just exposing in prefs is too little when it defaults to "on". We cannot send crash reports without users explicitely opting in, for privacy reasons. An opt-in at first crash as we do with Firefox OS could be enough, but that's the minimum the privacy team and IMHO our conscious requires (at least from all the discussions I had around this for FxOS).

Comment 9

[Jim Mathies [:jimm]]

Attachment: desktop options

Didn't even know we had these!

Comment 10

[Jim Mathies [:jimm]]

general->flyouts, 3 bugs

Comment 11

[Allison Naaktgeboren :ally]

This doesn't sound like its missing anything to make it actionable. [shovel-ready] ?

Comment 12

[Jim Mathies [:jimm]]

(In reply to :Ally Naaktgeboren from comment #11)
> This doesn't sound like its missing anything to make it actionable.
> [shovel-ready] ?

Think so, from where this left off, I believe we just need to tweak some strings and make sure the patch still works.

Comment 13

[Allison Naaktgeboren :ally]

strawman: priority 2
why: need it before release, or string freeze

Comment 14

[Allison Naaktgeboren :ally]

Attachment: desktoplike crashreporter strings, unrotted

Comment 15

[Allison Naaktgeboren :ally]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/c9e6ca6528b8

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c9e6ca6528b8

Comment 17

[Francesco Lodolo [:flod]]

Mobile just replaced Mozilla with &vendorShortName; in bug 871938. Not sure if this should apply to Metro as well.