844683 - scoped-style-pseudo-001.html and scoped-style-pseudo-002.html will fail on the next merge to mozilla-beta

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/?tree=Try&rev=5d630e18ce25 is the current mozilla-aurora pushed to try roughly as though it were mozilla-beta, saying that if we merged today, we'd wind up with permaorange in scoped-style-pseudo-001.html and scoped-style-pseudo-002.html.

Comment 1

[Phil Ringnalda (:philor)]

Hmm, and https://tbpl.mozilla.org/?tree=Try&rev=ada886f11c52 is aurora with only the update channel set to beta, but without changing the version from 21.0a2 to 21.0, and without the branding changes, passing those tests.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Ah, indeed, the version bump is the key, rather than the update channel, since all.js has:

// Is support for the :scope selector enabled?
#ifdef RELEASE_BUILD
pref("layout.css.scope-pseudo.enabled", false);
#else
pref("layout.css.scope-pseudo.enabled", true);
#endif

and http://hg.mozilla.org/mozilla-central/file/e48e1afb1899/config/rules.mk#l1229 has:

# Set a flag that can be used in pref files to disable features if
# we are not building for Aurora or Nightly.
ifeq (,$(findstring a,$(GRE_MILESTONE)))
PREF_PPFLAGS += -DRELEASE_BUILD
endif

which makes this expected.  I seem to have misremembered how RELEASE_BUILD was set.

Comment 3

[Phil Ringnalda (:philor)]

Tick tick tick, the merge clock is running, two weeks until this will be causing permaorange on mozilla-beta.

Comment 4

[Cameron McCormack (:heycam)]

I'll look at this in a week.

Comment 5

[Cameron McCormack (:heycam)]

Attachment: patch

Set the pref to enable :scope for these tests, as well as scoped-style-pseudo-003.html which doesn't actually fail but which does use :scope too.

Comment 6

[Phil Ringnalda (:philor)]

Comment on attachment 728809 [details] [diff] [review]
patch

r=me (though =tryserver would be more accurate), a=test-only, shipit!

Comment 7

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1ace686b691c
https://hg.mozilla.org/releases/mozilla-aurora/rev/286f3ec182e8

Comment 8

[Joe Drew (not getting mail)]

https://hg.mozilla.org/mozilla-central/rev/1ace686b691c

Comment 9

[Scoobidiver (away)]

Pushed to Aurora:
http://hg.mozilla.org/releases/mozilla-aurora/rev/286f3ec182e8