Closed
Bug 844684
Opened 10 years ago
Closed 10 years ago
GIF resource not displayed
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: sl.ostapenko, Assigned: jdm)
References
Details
Attachments
(2 files)
1.45 KB,
image/gif
|
Details | |
8.08 KB,
patch
|
joe
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:18.0) Gecko/20100101 Firefox/18.0 Build ID: 20130201190421 Steps to reproduce: Open attached sample.gif . Actual results: Image is not displayed, some generic icon is shown instead. Expected results: Image should be displayed. This particular - and many other similary 'broken' GIFs - image is served (in data:base64 format) by Amazon Cloud Reader, specifically when viewing 'Programming in Scala, Second Edition' by Odersky, Spoon, Venners. Similar bug also have reported for chromium: http://code.google.com/p/chromium/issues/detail?id=177561 Webkit fix is here: http://code.google.com/p/chromium/issues/detail?id=177561 Opera and IE are able to dispaly those gifs.
Updated•10 years ago
|
Status: UNCONFIRMED → NEW
Component: Untriaged → ImageLib
Ever confirmed: true
Product: Firefox → Core
Comment 1•10 years ago
|
||
We could use the same patch if we are still in sync with the chromium code
Comment 2•10 years ago
|
||
The WebKit version of this code was recently refactored to comply with the WebKit style guide, so there will be stylistic differences. The semantics of the necessary patch are likely to be identical, however.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → josh
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #717901 -
Flags: review?(joe)
Comment 4•10 years ago
|
||
Comment on attachment 717901 [details] [diff] [review] Decode GIFs that include an application extension string shorter than 11 bytes. Review of attachment 717901 [details] [diff] [review]: ----------------------------------------------------------------- Make sure bug 789046 isn't broken by this
Attachment #717901 -
Flags: review?(joe) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Tested an ASAN build with this patch, and loading both gifs from bug 789046 did not trigger any problems.
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca131cc6fdac
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ca131cc6fdac
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•