844725 - click-to-play: new placeholder content has some styling issues

Status: RESOLVED WORKSFORME

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Dirkjan Ochtman (:djc)]

Attachment: Screenshot of placeholder

- The "close" button should have the same margin on the right and on top
- The "Activate Adobe Flash." text should be further down from the play button
- I don't think a '.' at the end of a sentence fragment makes sense

Comment 1

[Benjamin Smedberg]

Can you post a screenshot of http://people.mozilla.com/~shorlander/ctp-test/ctp-test.html ?

I suspect that the close button is in the correct place, and just the plugin object is offset in a weird way. Shorlander will have to comment on the other things. See also bug 840414 which will probably fix the text positioning issue.

Comment 2

[Stephen Horlander [:shorlander]]

Yeah it looks like entire plugin container is getting clipped.

I agree with removing the period.

Comment 3

[Dirkjan Ochtman (:djc)]

Yeah, I noticed the close button is placed correctly in the placeholder on other sites (including the test page from comment 1). FWIW, the page where I previously took the screenshot also no longer has the weirdly placed close button. So I guess we can close this in favor of bug 840414, if the text placement (and the period) also get addressed there? Or would you prefer keeping the separate bug?

Comment 4

[Stephen Horlander [:shorlander]]

(In reply to Dirkjan Ochtman (:djc) from comment #3)
> Yeah, I noticed the close button is placed correctly in the placeholder on
> other sites (including the test page from comment 1). FWIW, the page where I
> previously took the screenshot also no longer has the weirdly placed close
> button. So I guess we can close this in favor of bug 840414, if the text
> placement (and the period) also get addressed there? Or would you prefer
> keeping the separate bug?

Closing this since it appears to be site specific. We are doing additional work on the strings and revising the visual design now that some of our goals have changed.