click-to-play: new placeholder content has some styling issues

RESOLVED WORKSFORME

Status

()

P3
normal
RESOLVED WORKSFORME
6 years ago
5 years ago

People

(Reporter: djc, Unassigned)

Tracking

(Depends on: 1 bug)

21 Branch
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 717764 [details]
Screenshot of placeholder

- The "close" button should have the same margin on the right and on top
- The "Activate Adobe Flash." text should be further down from the play button
- I don't think a '.' at the end of a sentence fragment makes sense
Priority: -- → P3

Updated

6 years ago
Blocks: 738698

Comment 1

6 years ago
Can you post a screenshot of http://people.mozilla.com/~shorlander/ctp-test/ctp-test.html ?

I suspect that the close button is in the correct place, and just the plugin object is offset in a weird way. Shorlander will have to comment on the other things. See also bug 840414 which will probably fix the text positioning issue.
Depends on: 840414
Yeah it looks like entire plugin container is getting clipped.

I agree with removing the period.
(Reporter)

Comment 3

6 years ago
Yeah, I noticed the close button is placed correctly in the placeholder on other sites (including the test page from comment 1). FWIW, the page where I previously took the screenshot also no longer has the weirdly placed close button. So I guess we can close this in favor of bug 840414, if the text placement (and the period) also get addressed there? Or would you prefer keeping the separate bug?
Flags: needinfo?(shorlander)
(In reply to Dirkjan Ochtman (:djc) from comment #3)
> Yeah, I noticed the close button is placed correctly in the placeholder on
> other sites (including the test page from comment 1). FWIW, the page where I
> previously took the screenshot also no longer has the weirdly placed close
> button. So I guess we can close this in favor of bug 840414, if the text
> placement (and the period) also get addressed there? Or would you prefer
> keeping the separate bug?

Closing this since it appears to be site specific. We are doing additional work on the strings and revising the visual design now that some of our goals have changed.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: needinfo?(shorlander)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.