844776 - Locales that currently use ISO-8859-1 as the fallback encoding should use windows-1252 instead

Status: RESOLVED WORKSFORME

(Core :: Internationalization, defect)

Description

[Henri Sivonen (:hsivonen)]

In in en-US, IE reports windows-1252 as the encoding when the fallback encoding is in use. Using the windows-1252 label rather than the ISO-8859-1 label is required by the Encoding Standard.

We should change the fallback encoding from ISO-8859-1 to windows-1252 in locales that currently use ISO-8859-1 as the fallback. This wouldn't change the decoder behavior—just the label reported.

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Change to the new canonical label

Comment 2

[Axel Hecht [:Pike]]

CCing Dwayne. I think changing the entries here without changing the keys is the right thing, but I'd like to hear from Dwayne on how that'll show on pootle. If it wouldn't show at all, that'd be fine, if it showed, we should make sure to not get a host of translations of windows-1252 or something by prior outreach.

Comment 3

[Henri Sivonen (:hsivonen)]

Bug 844461 will take care of locales that don't migrate right away. However, to land that patch, the test changes in this patch are needed. And the patch over in bug 844461 will need uplift ASAP, so if we're going to slow things down over here, I'll have to move the mochitest changes over.

Comment 4

[Simon Montagu :smontagu]

Comment on attachment 718982 [details] [diff] [review]
Change to the new canonical label

Review of attachment 718982 [details] [diff] [review]:
-----------------------------------------------------------------

OK with me, if Dwayne has no problem.

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 718982 [details] [diff] [review]
Change to the new canonical label

Review of attachment 718982 [details] [diff] [review]:
-----------------------------------------------------------------

I've got concerns here. We're having 4 values of intl.charset.default. Why would these depend on platform? And even more so, it seems to me that we're actually using the platform-dependent from global-platform (http://mxr.mozilla.org/mozilla-central/source/modules/libpref/src/init/all.js#1331) instead of the platform-independent one.

I'd rather see us remove the ones in platforms, and just use the one in global.

Comment 6

[Simon Montagu :smontagu]

(In reply to Axel Hecht [:Pike] from comment #5)
> I'd rather see us remove the ones in platforms, and just use the one in
> global.

That's bug 488433, and I think it's orthogonal to this bug

Comment 7

[Henri Sivonen (:hsivonen)]

Other bugs landed and made this one moot.