Update TabView - close() function to not use toLocaleUpperCase()

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: daniela.p98911, Assigned: balazs)

Tracking

unspecified

Firefox Tracking Flags

(firefox23 fixed, firefox-esr17 fixed)

Details

(Whiteboard: [mentor=andreea.matei][lang=js][good first bug])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
We need to update /lib/tabview.js library - close() function to not use toLocaleUpperCase() since bug 648294 was fixed.
Whiteboard: [mentor=andreea.matei][lang=js][good first bug]

Comment 1

5 years ago
Hey Andreea, been taking a look through tabview.js, but I don't see toLocaleUpperCase(). Any starting points you could give me?
Looks like this was fixed up to beta by the landing of the patch on bug 873473. So what we need here is a patch for the release and esr17 branch.
status-firefox23: --- → affected
status-firefox-esr17: --- → affected
Also Kyle for reference feel free to click on the 'Diff' link in the rev1.2 patch for that bug and you will see the removal, buried in among many other changes.

Comment 5

5 years ago
Comment on attachment 801018 [details] [diff] [review]
remove bug workarounds (mozilla-esr17) rev1.0

I wouldn't mind taking this, but as Andreea is the mentor and she's mentioned in the commit message, she was probably intended as reviewer here.
Attachment #801018 - Flags: review?(andrei.eftimie) → review?(andreea.matei)
Comment on attachment 801018 [details] [diff] [review]
remove bug workarounds (mozilla-esr17) rev1.0

Review of attachment 801018 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Juhasz,
Added it on esr17, on release it will be a merge today from beta so it's not needed anymore. 
I'll close the bug once that is done too.

Thanks!
http://hg.mozilla.org/qa/mozmill-tests/rev/109c4e3c622c (esr17)
Attachment #801018 - Flags: review?(andreea.matei) → review+
Merge is up, we have the changes in release too:
http://hg.mozilla.org/qa/mozmill-tests/file/mozilla-release/lib/tabview.js#l525

We're done here, Juhasz, thanks and you're welcome to help in other bugs if you want.
Assignee: nobody → juhaszbal
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-firefox23: affected → fixed
status-firefox-esr17: affected → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.