Closed
Bug 844787
Opened 12 years ago
Closed 11 years ago
Update TabView - close() function to not use toLocaleUpperCase()
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(firefox23 fixed, firefox-esr17 fixed)
RESOLVED
FIXED
People
(Reporter: daniela.p98911, Assigned: balazs)
References
Details
(Whiteboard: [mentor=andreea.matei][lang=js][good first bug])
Attachments
(1 file)
2.17 KB,
patch
|
AndreeaMatei
:
review+
|
Details | Diff | Splinter Review |
We need to update /lib/tabview.js library - close() function to not use toLocaleUpperCase() since bug 648294 was fixed.
Updated•12 years ago
|
Whiteboard: [mentor=andreea.matei][lang=js][good first bug]
Comment 1•11 years ago
|
||
Hey Andreea, been taking a look through tabview.js, but I don't see toLocaleUpperCase(). Any starting points you could give me?
Comment 2•11 years ago
|
||
Looks like this was fixed up to beta by the landing of the patch on bug 873473. So what we need here is a patch for the release and esr17 branch.
status-firefox23:
--- → affected
status-firefox-esr17:
--- → affected
Comment 3•11 years ago
|
||
Also Kyle for reference feel free to click on the 'Diff' link in the rev1.2 patch for that bug and you will see the removal, buried in among many other changes.
Assignee | ||
Comment 4•11 years ago
|
||
Removed workarounds (mozilla-esr17) for bug 648294 and bug 596504
Functional:
http://mozmill-crowd.blargon7.com/#/functional/report/fb97b6210ae70da1b9ace674459e1116
http://mozmill-crowd.blargon7.com/#/functional/report/fb97b6210ae70da1b9ace674459dd65e
Endurance:
http://mozmill-crowd.blargon7.com/#/endurance/report/fb97b6210ae70da1b9ace674459e4dff
Attachment #801018 -
Flags: review?(andrei.eftimie)
Comment 5•11 years ago
|
||
Comment on attachment 801018 [details] [diff] [review]
remove bug workarounds (mozilla-esr17) rev1.0
I wouldn't mind taking this, but as Andreea is the mentor and she's mentioned in the commit message, she was probably intended as reviewer here.
Attachment #801018 -
Flags: review?(andrei.eftimie) → review?(andreea.matei)
Comment 6•11 years ago
|
||
Comment on attachment 801018 [details] [diff] [review]
remove bug workarounds (mozilla-esr17) rev1.0
Review of attachment 801018 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks Juhasz,
Added it on esr17, on release it will be a merge today from beta so it's not needed anymore.
I'll close the bug once that is done too.
Thanks!
http://hg.mozilla.org/qa/mozmill-tests/rev/109c4e3c622c (esr17)
Attachment #801018 -
Flags: review?(andreea.matei) → review+
Comment 7•11 years ago
|
||
Merge is up, we have the changes in release too:
http://hg.mozilla.org/qa/mozmill-tests/file/mozilla-release/lib/tabview.js#l525
We're done here, Juhasz, thanks and you're welcome to help in other bugs if you want.
Assignee: nobody → juhaszbal
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•