Closed Bug 844805 Opened 7 years ago Closed 7 years ago

Don't call FoldConstants from Parser::memberExpr()

Categories

(Core :: JavaScript Engine, defect)

Other Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: jorendorff, Assigned: jorendorff)

References

(Depends on 1 open bug)

Details

(Whiteboard: [js:t])

Attachments

(3 files, 2 obsolete files)

We know which calls are generator-expr calls; there's a different parse node kind.
Also:

            /*
             * Do folding so we don't have roundtrip changes for cases like:
             * function (obj) { return obj["a" + "b"] }
             */
            if (foldConstants && !FoldConstants(context, &propExpr, this))
                return NULL;
Whiteboard: [js:t]
Assignee: general → jorendorff
The call in unaryExpr() dates back to 2009, introduced in bug 382355.

It is not necessary anymore at least since PNK_GENEXP was introduced.
Attached patch v1 (obsolete) — Splinter Review
Why is this patch so big?

Consider `obj["a" + "b"]`. We want to emit the same bytecode as for `obj.ab`.

This is a two-step optimization, first this:
  "a" + "b" ==> "ab"
then this:
  obj["ab"] ==> obj.ab

Both optimizations must happen, in that order.

Before this patch, the second optimization was implemented in the parse phase. But the first is implemented in FoldConstants. To get both, in the right order, the parser had to call FoldConstants immediately before attempting the second optimization.

Sounds slow, right? I even considered that this might be a counterexample to Brendan's claim that every O(n^2) hack has come back to bite -- this FoldConstants call has his fingerprints on it, and doesn't seem to have bitten us. But it turns out it's only O(n*d) where d is our recursion depth limit, in this case just under 2000 in a debug build on my MacBook.

The fix is to put both optimizations in FoldConstants where they belong.

The determination that an array or object literal is constant belongs in FoldConstants as well. Someday.

In the most extreme case I could contrive, below, this patch reduces the number of FoldConstants calls from 3,972,051 (363 msec in a DEBUG build) to 3,991
(6 msec).


var a = "x";
for (var i = 0; i < 1992; i++)
    a = "x[" + a + "]";

var t0 = Date.now();
var f = Function(a);
var t1 = Date.now();
print(t1 - t0);
Attachment #765114 - Flags: review?(jwalden+bmo)
Comment on attachment 765114 [details] [diff] [review]
v1

Retracting; this patch is as busted as can be. If not more so.
Attachment #765114 - Flags: review?(jwalden+bmo)
OK, this isn't the most straightforward fix, but it is more satisfying if you want to see ParseNode::pn_op go away.

The bug with my previous patch was that I wasn't setting pn_op=JSOP_SETPROP on a particular PNK_DOT node that I created in FoldConstants. Well, that bug should be unpossible.

The purpose of this "part 1" patch is to make the BytecodeEmitter stop
looking at the pn_op field of PNK_DOT and PNK_ELEM nodes (except to assert
that their values are exactly what we expect).

In the next patch I actually set pn_op to JSOP_NOP on those nodes (and
remove the assertions, of course).

- EmitPropLHS has an in-out parameter, op, which should be
  in-only. EmitPropLHS only writes to *op in one specific case
  which the caller can easily figure out beforehand.

  (In fact I changed it so that the *grandcaller*, EmitCallOrNew,
  figures it out, which turns out to be exactly what the adjacent
  PNK_ELEM case does.)

- Likewise the callContext argument becomes redundant, if the caller
  passes the correct op.

- Deleted a redundant BindNameToSlot call. Proof that it's redundant:
  in that path we have pn2->isKind(PNK_NAME), which means the whole
  pn2->isKind(PNK_DOT) block is skipped; we'll call EmitTree on pn2,
  which will call EmitNameOp, which will call BindNameToSlot.

- Changed each EmitAtomOp and EmitElemOp call site to hard-code the op,
  and add assertions that I'm not changing the behavior.
Attachment #765114 - Attachment is obsolete: true
Attachment #766165 - Flags: review?(jwalden+bmo)
Comment on attachment 766165 [details] [diff] [review]
Part 1 - Don't use pn_op of PNK_DOT/ELEM nodes

Review of attachment 766165 [details] [diff] [review]:
-----------------------------------------------------------------

This looks reasonably right, although I'm not 100% confident in its exact correctness.  My puny mind cannot fully comprehend all the twistings of this at once, sadly, but that's why we have tests and fuzzers.  :-)  Let's lean on them more!

::: js/src/frontend/BytecodeEmitter.cpp
@@ -1861,5 @@
>      return true;
>  }
>  
>  static bool
> -EmitPropLHS(JSContext *cx, ParseNode *pn, JSOp *op, BytecodeEmitter *bce, bool callContext)

Yayayayayayayay callContext goes away!  \o/
Attachment #766165 - Flags: review?(jwalden+bmo) → review+
Comment on attachment 766166 [details] [diff] [review]
Part 2 - Don't even set the pn_op field of PNK_DOT/ELEM nodes

Review of attachment 766166 [details] [diff] [review]:
-----------------------------------------------------------------

\o/ \o/ \o/
Attachment #766166 - Flags: review?(jwalden+bmo) → review+
Comment on attachment 766168 [details] [diff] [review]
Part 3 - Previous patch unchanged except for line numbers

Review of attachment 766168 [details] [diff] [review]:
-----------------------------------------------------------------

\o/ \o/ \o/
Attachment #766168 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/3f152e51be2b
https://hg.mozilla.org/mozilla-central/rev/5428fa083db3
https://hg.mozilla.org/mozilla-central/rev/c39ede0eea8f
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
This caused a perf regression (bug 887266) so I backed it out.

But I know what it is. Patch coming.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
The interdiff from v1 is:

>diff --git a/js/src/frontend/ParseNode.h b/js/src/frontend/ParseNode.h
>--- a/js/src/frontend/ParseNode.h
>+++ b/js/src/frontend/ParseNode.h
>@@ -789,0 +789,5 @@ class ParseNode
>+    template <class NodeType>
>+    inline bool is() const {
>+        return NodeType::test(*this);
>+    }
>+
>
>diff --git a/js/src/frontend/FullParseHandler.h b/js/src/frontend/FullParseHandler.h
>--- a/js/src/frontend/FullParseHandler.h
>+++ b/js/src/frontend/FullParseHandler.h
>     PropertyName *isGetProp(ParseNode *pn) {
>-        return pn->isOp(JSOP_GETPROP) ? pn->pn_atom->asPropertyName() : NULL;
>+        return pn->is<PropertyAccess>() ? &pn->as<PropertyAccess>().name() : NULL;
>     }
Attachment #766166 - Attachment is obsolete: true
Attachment #768162 - Flags: review?(jwalden+bmo)
Ahh, the f.apply optimization...

Various people have remarked recently that it would be nice if we had an API in shell so that we could test whether various optimizations were applied and this is another case where it would have been nice to get a simple jit_test failure.  The old thing we exposed for trace tests was extremely fickle, but I bet we could do better than that.
Comment on attachment 768162 [details] [diff] [review]
Part 2 - Don't even set the pn_op field of PNK_DOT/ELEM nodes, v2

Review of attachment 768162 [details] [diff] [review]:
-----------------------------------------------------------------

Boooooo, isOp.
Attachment #768162 - Flags: review?(jwalden+bmo) → review+
Depends on: 888002
In bug 887266 Hannes says that the *backout* also caused perf regressions! I can't find evidence of this on awfy but I'm sure I'm just not looking in the right place. In the meantime I'll investigate bug 888002 and see if we can get this re-landed...
Our frontend is a bit brittle, it seems. :(

Removing the FoldConstants call in Parser::unaryExpr() changed the behavior of a bug that I didn't know we had. The new behavior triggered an assertion instead of just user-visible non-spec-compliant behavior.

I've filed a patch to fix that newly discovered bug *and* re-remove the FoldConstants call in bug 888002.
Resummarizing. This bug will only remove one FoldConstants call; the other one bites the dust in 888002.
Summary: Don't call FoldConstants from Parser::unaryExpr() → Don't call FoldConstants from Parser::memberExpr()
You need to log in before you can comment on or make changes to this bug.