84485 - [PATCH]Pasting link into last bullet item created havoc in my list.

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P1)

Description

[selmer (gone)]

6/7 Branch

Pasting link into last bullet item created havoc in my list.

Create a list with lots of items.  Paste links into all of them and add text
after each paste.  After pasting a link into the last item in the list:
    
    *  I'm in a state where double returns don't terminate list building.  (If
you hit return fast enough, you can also get this behavior. I originally created
the list by creating an item and then hitting return 8 or 10 times very fast and
got a bullet for each return.)  
    * here at the end of the list though, it's for a different reason.  Once I
had all those bullets, I dragged bug links into the email and added text. 
everything was fine until I did that on the last item in the list.  When I first
pasted it, it "missed" its bullet and was drawn near the left margin with its
bullet below the text.  Attempts to undo and delete and cut and paste followed
leaving me with psuedo-dual bullets (visually in the editor anyway.)  The
vertical spacing was all off until I created these bullets at the end here.

a *lot* of work goes into correcting a problem like this during the edit session
and requires doing things most users would be unlikely to try.

Comment 1

[rubydoo123]

I have been able to reproduce this, but you have to follow these steps EXACTLY
to reproduce it. Also, I am able to reproduce it in mail compose and composer.

1. open a new composer window
2. insert a list
 -- 1st list item enter text
 -- 2nd list item enter text
3. drag a link to the end of the 2nd list item, hit enter
4. while the caret is in the 3rd list item, press the left arrow so the caret
moves to the end of the 2nd list item
5. hit return, a new blank list item will be inserted, continue to hit return,
additional list items are inserted and the list does not terminate. 

Additional information:

-- doing this same test without the link at the end of the 2nd bullet does not
produce the same effect, the list is terminated.

using the trunk build from 7 June on win98

Comment 2

[rubydoo123]

talked with Joe, he believes this is an easy fix with high return on usability

reviewed and approved

Comment 3

[rubydoo123]

must move this to 1.0, engineer is on sabbatical

Comment 4

[rubydoo123]

clearing the nsbranch keyword so as not to be confused with the current set of 
nsbranch bugs.

Comment 5

[Joe Francis]

097

Comment 6

[Syd Logan]

plusing, but could it be some or all of the issue has been resolved by now?

Comment 7

[Joe Francis]

099 to 1.0; set pri to 1 for these pushed off EB+ bugs

Comment 8

[rubydoo123]

removing myself from the cc list

Comment 9

[Joe Francis]

This is fixed by my patch to 132837

Comment 10

[Joe Francis]

Remember to test the following:  make a list with a link at the end of last
item.  Click at end of link.  Hit return to make new list item.  From that
situation make sure these work:
1) indent
2) outdent
3) deletion (backspace & forward delete)

Comment 11

[Joe Francis]

fix landed on trunk

Comment 12

[selmer (gone)]

Using 4/8 03 trunk build, doesn't seem completely fixed to me.

I took an existing email with nested lists in it (my last status report) and
copied a link from within the mail and pasted it into the last item in one of
the indented lists.  When I then hit return multiple times I got multiple list
items and eventually the input cursor moves to the next item in the parent list
(without ever terminating the inner list.)  From there, hitting enter creates
new items in the parent list.

Using ^Z worked flawlessly in this test and I didn't get any strange
indentation, so it's *loads* better than what I reported after this fix!

Is this worth reopening, or is what I'm seeing now a "different" bug?

Comment 13

[Joe Francis]

Is it possible to get a simple testcase?  

Comment 14

[selmer (gone)]

1.  Open Composer to a new document
2.  create a list with several elements and a single character in each bullet
3.  position at the end of the first element of the list and hit enter to get a
new bullet
4.  indent the bullet, add text, hit enter
5.  add text, paste a link hit enter
6.  hit enter
7.  notice that you now have 2 blank bullets in the indented list and the caret
is positioned at the next element of the outer list.
8.  hit enter
9.  notice that you've now created a new bullet in the outer list.

Comment 15

[Joe Francis]

Thanks Steve, this is very clear.  Step 7 is the unexpected behavior.  *GIVEN* 
step 7, step 9 is actually expected, since hitting return in non-empty list items 
splits the item (even if one side of split is empty).

Step 7 probable has a cause different from original bug.  I'll open a new bug.

Comment 16

[sujay]

Ths issue that selmer brings up has been filed as bug 136504

Comment 17

[selmer (gone)]

The positioning of the caret at the outer list element was surprising to me. 
Was that the correct behavior if it had closed off the list?  I guess it might be.

Comment 18

[sujay]

marking this bug verified...

other issues are covered by these bugs:

136504
135337