844872 - All addons and search engines present an option section even when the plugin does not have any options

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Add-on Manager, defect)

Description

[Adrian Tamas (:AdrianT)]

Attachment: screenshot

Firefox Mobile 21.0a2 2013-02-24
Samasung Galaxy Tab 2 (Android 4.0.4)

Steps to reproduce:
1. Open the Add-on Manager
2. Open any of the add-ons or search engines

Expected results:
The options section is not displayed unless the addon/search engine has options

Actual results:
The Options section is present even when the addon/search engine does not have any options

Notes:
This is not reproducible on Firefox Mobile 19

Comment 1

[Aaron Train [:aaronmt]]

Adrian, can you find a regression range for this?

Comment 2

[Andreea Pod]

The regression window for this issue is:
good build: 01.12.2012  
bad build:  02.12.2012  

possible pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d2fbc67f69f5&tochange=0352a32fde64

Comment 3

[Aaron Train [:aaronmt]]

Hm, nothing really stands out

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

I'm going to bisect this manually.

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Even though this is a regression, it doesn't appear to be a release blocking issue unless in your testing/bisecting you discover actual functionality regressions - in that case please renom.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

This only seems to happen with search eninges, which are "faked" as add-ons. We missed faking the optionsURL. Patch coming.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

* Adds the optionsURL placeholder for search engines.
* Removes the Cu.reportError (it's not an error)
* Unwrapped a line cause I hate that

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ee634efa5f4b

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ee634efa5f4b

Comment 10

[Aaron Train [:aaronmt]]

Verified fixed on trunk