HTML in Panel example does not declare encoding

RESOLVED FIXED

Status

Add-on SDK
Documentation
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: canuckistani, Assigned: canuckistani)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

If Panel html doesn't declare encoding, Firefox will produce errors in the JS console:

Timestamp: 2013-02-25 9:11:13 AM
Error: The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol.
Source File: resource://jid1-xsm0l5ractpyaq-at-jetpack/panel-test/data/panel.html
Line: 0

the AMO Editors have a policy that add-ons should not produce errors, and errors like these run afoul of this policy, although they are tolerated.

We should make sure that html examples in the docs include an encoding declaration, eg:

https://addons.mozilla.org/en-US/developers/docs/sdk/1.13/modules/sdk/panel.html

Comment 1

5 years ago
Created attachment 717923 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/812

Pointer to Github pull-request

Updated

5 years ago
Priority: -- → P2

Comment 2

5 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/fe586d279ccdb151b60c430c36232af12f4ff89f
bug 844898, html examples for panels should declare text encoding to avoid dumping errors to the console.

https://github.com/mozilla/addon-sdk/commit/924d09e8535d1ec325891c1e0aaf9234f89e5df7
Merge pull request #812 from canuckistani/bug_844898_panel_html_encoding

bug 844898, html examples for panels should declare text encoding r=@gozala
This is fixed, right?
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.