Closed
Bug 844905
Opened 11 years ago
Closed 11 years ago
Change MediaResource::GetContentType return type to nsCString.
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(1 file)
|
3.00 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
After recent WMF patches from bug 839031, mingw-w64 64-bit builds fail with error: WMFByteStream.cpp:165:5: error: cannot pass objects of non-trivially-copyable type ‘const class nsCString’ through ‘...’ I'm not sure how MSVC manages to pass it, but it's tricky in win64 ABI. The thing that we really want to pass here is string buffer pointer, which is much easier if we change GetContentType to return nsCString. It's gree on try (build only run): https://tbpl.mozilla.org/?tree=Try&rev=9802b61347c6
Attachment #717928 -
Flags: review?(cpearce)
|
||
Updated•11 years ago
|
Attachment #717928 -
Flags: review?(cpearce) → review+
|
Assignee | |
Comment 1•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a936abbcf23f
|
||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a936abbcf23f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•