844959 - Tabs are hidden after a tap on privacy tab button and a rotation

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Julien Vermet | JulienDev]

Attachment: tabs.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:22.0) Gecko/20130221 Firefox/22.0
Build ID: 20130221072044

Steps to reproduce:

Prerequisites : 
* Normal mode (No privacy)
* No privacy tab opened
* Portrait mode

1. Tap tabs counter
2. Tap privacy tab button
3. Rotate device (to landscape)
4. TwoWayView height is null
5. Tap normal tab button


Actual results:

TwoWayView height is still null despite I have tabs opened


Expected results:

TwoWayView shows tabs opened with normal mode

Comment 1

[Aaron Train [:aaronmt]]

I'm unable to reproduce your #4; on rotation I see the tabs positioned horizontally. Are you missing a step?

Comment 2

[Lucas Rocha (:lucasr)]

I know what's going on here. Working on it.

Comment 3

[Andreea Pod]

I am able to reproduce this on:
-build: Firefox for Android 22.0a1 (2013-02-25)
-device: Samsung Galaxy Nexus
-OS: Android 4.2.2

Comment 4

[Lucas Rocha (:lucasr)]

Attachment: Set an explicit height for horizontal tabs tray

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 725609 [details] [diff] [review]
Set an explicit height for horizontal tabs tray

Works OK on phones and tablets?

Comment 6

[Lucas Rocha (:lucasr)]

(In reply to Mark Finkle (:mfinkle) from comment #5)
> Comment on attachment 725609 [details] [diff] [review]
> Set an explicit height for horizontal tabs tray
> 
> Works OK on phones and tablets?

Yep, tested on all form factors.

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/e83371a150ef

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e83371a150ef