844962 - [socorro-crashstats] 500 when loading topcrasher with product=None

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Robert Helmer [:rhelmer]]

Getting a lot of these tracebacks via email:

BadStatusCodeError: 500: on: http://socorro-mware-stage-zlb.webapp.phx1.mozilla.com/bpapi/bugs/

Looks like it's mostly spiders hitting paths like:

/topcrasher/products/B2G/versions/21.0a1/date_range_type/report/crash_type/content/os_name/None

This causes us to send an invalid request to the bug service, we should catch this invalid os_name much earlier than this. Also, we should figure out how the spiders are getting this in the first place.

Comment 1

[Peter Bengtsson [:peterbe]]

I'd rather we try to find out how the heck the spiders go to URLs that contain `None`.

Comment 2

[Robert Helmer [:rhelmer]]

(In reply to Peter Bengtsson [:peterbe] from comment #1)
> I'd rather we try to find out how the heck the spiders go to URLs that
> contain `None`.

Indeed :) They must be getting the link from somewhere.

Comment 3

[Robert Helmer [:rhelmer]]

(In reply to Robert Helmer [:rhelmer] from comment #2)
> (In reply to Peter Bengtsson [:peterbe] from comment #1)
> > I'd rather we try to find out how the heck the spiders go to URLs that
> > contain `None`.
> 
> Indeed :) They must be getting the link from somewhere.

b2g reporting (on the postgres side) isn't hooked up yet, and we're not handling it very gracefully in general - see https://crash-stats-django.allizom.org/topcrasher/products/B2G/versions/19.0a2 for example (you can get there just using the pulldown menus)

Comment 4

[Peter Bengtsson [:peterbe]]

PR https://github.com/mozilla/socorro-crashstats/pull/306

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/8d62d72eeebee18244141bb9b660665af0dde5d6
bug 844962 - topcrashes with os_name None sometimes

https://github.com/mozilla/socorro-crashstats/commit/04a0313bcd7b4da7c49377053caf6242ac8733a4
Merge pull request #306 from peterbe/bug844962-topcrashes-with-os_name-none-sometimes

bug 844962 - topcrashes with os_name None sometimes