844973 - New Account Screen - Layout and Type updates

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Eric Pang [:epang] UX]

Attachment: Email New Account Mock Up

Changes to this screen:
1. Being a account setup screen the dark header should be used.
2. Subheader bar has been added (same styling as settings)
3. Font and layout has been updated (refer to specs attached to meta bug https://bugzilla.mozilla.org/show_bug.cgi?id=841512)
4. Button stretched (15px margins)

Comment 1

[Eric Pang [:epang] UX]

(In reply to Eric Pang [:epang] from comment #0)
> Created attachment 718004 [details]
> Email New Account Mock Up
> 
> Changes to this screen:
> 1. Being a account setup screen the dark header should be used.
> 2. Subheader bar has been added (same styling as settings)
> 3. Font and layout has been updated (refer to specs attached to meta bug
> https://bugzilla.mozilla.org/show_bug.cgi?id=841512)
> 4. Button stretched (15px margins)

sorry wrong link for specs, here's the correct one: https://bugzilla.mozilla.org/show_bug.cgi?id=839220

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Eric, your before picture is still very out-of-date relative to gaia/master.  The account setup screen already has the dark header, "manual setup" is a link now instead of a button, etc.  You need to be using a build from gaia/master as your ground truth.

Comment 3

[Eric Pang [:epang] UX]

(In reply to Andrew Sutherland (:asuth) from comment #2)
> Eric, your before picture is still very out-of-date relative to gaia/master.
> The account setup screen already has the dark header, "manual setup" is a
> link now instead of a button, etc.  You need to be using a build from
> gaia/master as your ground truth.

Hi Andrew, I currently don't have a device on me, but I will update my build to be from gaia/master tomorrow morning.  I'll update the before screens and make changes to the mock ups accordingly. thx!

Pavel, i'm going to continue breaking the meta bug into individual bugs, but hold off on fixes for the time being while I gather the latest before images.  I'll let you know when I've finished updating everything.  Thx!

Comment 4

[Eric Pang [:epang] UX]

Attachment: Updated Email New Account Mock Up

1. Layout updates
	a. 15px spacing under header
	b. 15px side margins for input 
	     boxes
	c. 30 px left margin for type
2. “Account” in header is capitalized

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: After patch

Comment 6

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #5)

background will be removed here : https://github.com/pivanov/gaia/commit/a1340a8b26b5cb893ddfaccb9fcf4dd6ca6a2a1a#L2L1

Comment 7

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for UX branch

Comment 8

[Andrew Sutherland [:asuth] (he/him)]

Why is this pull request against the UX branch instead of gaia/master?

Comment 9

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

We do all the visual changes/improvements in UX Branch first. If the rest of the UX guys are ok we can use gaia/master directly.

Comment 10

[Andrew Sutherland [:asuth] (he/him)]

It made sense to do changes on the UX branch when we could not land UX changes on gaia/master.  But we've been able to land UX changes on gaia/master for quite some time now.  All that landing changes on the UX branch accomplishes is a good chance that the patches will never make it to gaia/master, or that they will be bit-rotted by changes that did land on gaia/master.

Comment 11

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #9)
> We do all the visual changes/improvements in UX Branch first. If the rest of
> the UX guys are ok we can use gaia/master directly.

Hi Pavel, this shouldn't be a problem.

Comment 12

[Sam Joch [:samjoch]]

Landed in uxbranch: https://github.com/gordonbrander/gaia/commit/a81c8ee35c97710737f79f0ffc72551bacaad01f

Comment 14

[Sam Joch [:samjoch]]

https://github.com/mozilla-b2g/gaia/commit/e45b5592bf5b82ddbeda5be2be18a26b191d55fb

Comment 15

[Julien Wajsberg [:julienw]]

Landed to v1-train as part of the Big Bug 851124 uplift.
(but not to v1.0.1).

Comment 16

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

v1 train and master verified

Master build : 2013-03-26-07-02-04
"mozilla-central" revision="28b048ffb7a7"
"integration/gaia-central" revision="44f6a17f24d4"
"gecko.git"revision="a800f14ea7022a78966f7fe14a9b0d11c569b151"
"gaia.git" revision="ace1eb32a313da1232bbdf9cff2581a4b036356d"

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/28b048ffb7a7
Gaia   ace1eb32a313da1232bbdf9cff2581a4b036356d
BuildID 20130326070204
Version 18.0
Unagi