Closed Bug 84498 Opened 23 years ago Closed 23 years ago

xpidl_process_idl may return unitialized value.

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.4

People

(Reporter: mozilla-bugs, Assigned: dbradley)

References

(
URL
)

Details

(Whiteboard: review)

Attachments

(1 file)

Adds initilization of ok in xpidl_process_idl
498 bytes, patch
Details | Diff | Splinter Review 
xpidl_idl.c: In function `xpidl_process_idl':
xpidl_idl.c:630: warning: `ok' might be used uninitialized in this function
Looks like you just need to init ok to TRUE.
Assignee: kandrot → dbradley
Component: XPCOM → xpidl
QA Contact: scc → pschwartau
My first thought was FALSE, but then I I saw that failure is treated somewhat 
like success.

I'll attach a patch
Status: NEW → ASSIGNED
Keywords: review
Target Milestone: --- → mozilla0.9.2
r=beard
Blocks: 59652
Need a review to wrap this bug up.
Whiteboard: review
sr=scc
Target Milestone: mozilla0.9.2 → mozilla0.9.3
Moving out.
Target Milestone: mozilla0.9.3 → mozilla0.9.4
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Patch committed.
Marking Verified -
Status: RESOLVED → VERIFIED
Component: xpidl → XPCOM
QA Contact: pschwartau → xpcom
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: