845016 - IonMonkey: Inline Math.abs on differing input/output types

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Shu-yu Guo [:shu]]

We should inline Math.abs with double input and int output. Int input and double output is an impossible combination.

Comment 1

[Shu-yu Guo [:shu]]

Attachment: patch

Comment 2

[Sean Stangl [:sstangl]]

Comment on attachment 718041 [details] [diff] [review]
patch

Just as a note, MToInt32 -> visitDoubleToInt32() contains a negative zero test and a bailout, which is obviously impossible in this scenario. We could optimize it better -- perhaps even doing the testing and negation on integers.

Comment 3

[Nicolas B. Pierron [:nbp]]

(In reply to Shu-yu Guo [:shu] from comment #0)
> We should inline Math.abs with double input and int output. Int input and
> double output is an impossible combination.

Except for INT_MIN, but this would work as soon as we support UInt32.

Comment 4

[Shu-yu Guo [:shu]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/b9bdc1d96b6a

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b9bdc1d96b6a