845073 - Delete Email screen update

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Eric Pang [:epang] UX]

Attachment: Delete Email Screen mock up

Changes:
1. Moved type to 30px left margin

Comment 1

[Eric Pang [:epang] UX]

Attachment: Updated Delete Email Screen mock up

See attached image for list of changes

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: After patch

Hey Eric,
we need to do this on all confirm dialogs, right? Because this is a part of [BB][confirm] dialogs.

Comment 3

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #2)
> Created attachment 724805 [details]
> After patch
> 
> Hey Eric,
> we need to do this on all confirm dialogs, right? Because this is a part of
> [BB][confirm] dialogs.

Hi Pavel, yes that makes sense. thx

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia repo

Comment 5

[Eric Pang [:epang] UX]

LG request for font updates.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Mass edit to set tracking-b2g18+ for these UX bugs that were called out for v1.1

Comment 7

[Kevin Grandon :kgrandon]

Landed in master: https://github.com/mozilla-b2g/gaia/commit/ab067088fde35e25dd0137add7db55405a0a08c1

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

verified in master

## Environment :
Master build : 2013-04-05-03-05-43
name="mozilla-central" revision="55f9e3e3dae7"  
name="integration/gaia-central" revision="2005e026bdae"
"gecko.git" revision="66b64f47a4eac1bd4f5ea6748b42ddf732297550"
"gaia.git" revision="15468abcba0dd2549f0c102df887

Comment 9

[Sergi]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #2)
> Created attachment 724805 [details]
> After patch
> 
> Hey Eric,
> we need to do this on all confirm dialogs, right? Because this is a part of
> [BB][confirm] dialogs.

hey guys, right now we are not using what you're proposing in the system component you want to change. It's ok with me you make style changes to building blocks and system components, but i'm a little bit concerned about the way you're doing these changes because we should reflect this for all the instances of that same component, so the changes you propose here should be also updated in the documentation we're providing (i.e. through the BB wiki).

Do you have any suggestion on how we should approach this?

Thanks

Comment 10

[Kevin Grandon :kgrandon]

It would be very nice to capture this change in Building blocks, and the respective documentation, then remove the customization here later.

Comment 11

[Eric Pang [:epang] UX]

(In reply to Sergi from comment #9)
> (In reply to Pavel Ivanov [:ivanovpavel] from comment #2)
> > Created attachment 724805 [details]
> > After patch
> > 
> > Hey Eric,
> > we need to do this on all confirm dialogs, right? Because this is a part of
> > [BB][confirm] dialogs.
> 
> hey guys, right now we are not using what you're proposing in the system
> component you want to change. It's ok with me you make style changes to
> building blocks and system components, but i'm a little bit concerned about
> the way you're doing these changes because we should reflect this for all
> the instances of that same component, so the changes you propose here should
> be also updated in the documentation we're providing (i.e. through the BB
> wiki).
> 
> Do you have any suggestion on how we should approach this?
> 
> Thanks

Hi Sergi, i plan to look into this.  I'll go through the BB Wiki and see what updates we need to make (I think it will just be font sizes).  I'll come up with final designs and run them by you and Victoria.  Then hopefully we can have all confirmation screens updated to be consistent (I plan to do the same for system and progress screens).  Sorry for the confusion, thanks!

Comment 12

[Eric Pang [:epang] UX]

Attachment: Updated Delete Email Screen mock up

Hi Pavel,
I've updated this screen to follow the BB, see image for layout details.  I will also attach the font spec shortly.  This is the spec we should follow for all confirmation screens.  Would it make more sense to open a new [BB] bug for this? Let me know, thanks!

Comment 13

[Eric Pang [:epang] UX]

Attachment: Font Specs

Comment 14

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: Followup Patch

I will add images later (bad connection at this moment)

Comment 15

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #14)
> Created attachment 739640 [details]
> Followup Patch
> 
> I will add images later (bad connection at this moment)

ok, thanks Pavel! Flag me for feedback when you've added it.  thx!

Comment 16

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

so ... I think we need to update the spec because here (https://bug863323.bugzilla.mozilla.org/attachment.cgi?id=740850) we use margin left/right 15px for the line, right?

Comment 17

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #16)
> so ... I think we need to update the spec because here
> (https://bug863323.bugzilla.mozilla.org/attachment.cgi?id=740850) we use
> margin left/right 15px for the line, right?

That's right Pavel, can you adjust?  Thanks!

Comment 18

[Eric Pang [:epang] UX]

(In reply to Eric Pang [:epang] from comment #17)
> (In reply to Pavel Ivanov [:ivanovpavel] from comment #16)
> > so ... I think we need to update the spec because here
> > (https://bug863323.bugzilla.mozilla.org/attachment.cgi?id=740850) we use
> > margin left/right 15px for the line, right?
> 
> That's right Pavel, can you adjust?  Thanks!

Also, can this be done by using the BB?

Comment 19

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #16)
> so ... I think we need to update the spec because here
> (https://bug863323.bugzilla.mozilla.org/attachment.cgi?id=740850) we use
> margin left/right 15px for the line, right?

Pavel, in Bluetooth app they are linking to incorrect BB which were copied from system:
  <link rel="stylesheet" type="text/css" href="style/bb/value_selector.css" />
  <link rel="stylesheet" type="text/css" href="style/bb/menus-dialogues/core.css" />
  <link rel="stylesheet" type="text/css" href="style/bb/menus-dialogues/prompt/style.css" />

I already fixed the margins in Confirm BB, we should be replacing these 3 links for Confirm BB.
But that should probably be done in a different bug, and try to close this one to avoid further issues.

Comment 20

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

(In reply to arnau from comment #19)

Thanks :) I just opened 868550