845105 - Calendar Week View Screen Updates

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Eric Pang [:epang] UX]

Attachment: Calendar Week View Mock Up

See image attachment for detailed changes.

Comment 1

[Eric Pang [:epang] UX]

Part of LG's request for font updates.

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

Mass edit to set tracking-b2g18+ for these UX bugs that were called out for v1.1

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: After patch

See point 3 in this screenshot :)

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia repo

Comment 5

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #3)
> Created attachment 731541 [details]
> After patch
> 
> See point 3 in this screenshot :)

Hi Pavel, yes number 3 was a mistake it's #ffffff, sorry!
One change: The blue is too dark, can you change the value to #2951a6? (for anywhere the blue is used in calendar). Thanks!

Comment 6

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

We use some colors from here http://en.wikipedia.org/wiki/ANSI_escape_code#graphics and I can't change them.

Comment 7

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #6)
> We use some colors from here
> http://en.wikipedia.org/wiki/ANSI_escape_code#graphics and I can't change
> them.

Ok, if it can't be changed, everything else looks good. Thanks!

Comment 8

[Sam Joch [:samjoch]]

Landed in master https://github.com/mozilla-b2g/gaia/commit/9a563d35104bebdd7e6931d4f325cb08b078e4c2

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

verified:
Master build : 2013-04-05-03-05-43
name="mozilla-central" revision="55f9e3e3dae7"  
name="integration/gaia-central" revision="2005e026bdae"
"gecko.git" revision="66b64f47a4eac1bd4f5ea6748b42ddf732297550"
"gaia.git" revision="15468abcba0dd2549f0c102df887a5c049b9c641"
Unagi

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 731542 [details]
patch for Gaia repo

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): UX polishing
User impact if declined: User cannot see proper visualization of the calendar event, causing some misunderstandings on when some events finish.
Testing completed: Yes
Risk to taking this patch (and alternatives if risky): LOW, as it's just CSS change
String or UUID changes made by this patch:

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Francisco Jordano [:arcturus] from comment #10)

> String or UUID changes made by this patch:

https://github.com/mozilla-b2g/gaia/commit/9a563d35104bebdd7e6931d4f325cb08b078e4c2

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 9a563d35104bebdd7e6931d4f325cb08b078e4c2 as:
v1-train: 558093ce525f2e5b97a2bd74c737f4c3e749aeef