Closed Bug 845115 Opened 12 years ago Closed 12 years ago

Calendar - Account Details Screen Update

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Calendar
Platform:
All
Other
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g18+ fixed)

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
b2g18 + fixed

People

(Reporter: epang, Assigned: pivanov)

References

Details

(Keywords: polish, Whiteboard: visual design, UX-P1, yedo, landed in uxbranch)

Attachments

(3 files, 1 obsolete file)

Calendar - Account Details Screen Mock Up
61.90 KB, image/png
Details
patch for Gaia repo
181 bytes, text/html
kgrandon
: review+
lsblakk
: approval-gaia-v1+
Details
After patch
73.53 KB, image/png
Details
See image attachment for detailed changes.
Blocks: 843818
No longer depends on: 843818
blocking-b2g: --- → leo?
Part of LG's request for font updates.
Mass edit to set tracking-b2g18+ for these UX bugs that were called out for v1.1
tracking-b2g18: --- → +
blocking-b2g: leo? → ---
Attached image After patch (obsolete) —
Attached file patch for Gaia repo —
Attachment #728745 - Flags: review?(sjochimek)
Blocks: 845121
(In reply to Pavel Ivanov [:ivanovpavel] from comment #3) > Created attachment 728744 [details] > After patch Pavel, can you check if the text size in the input fields 17px? thx!
Attachment #728744 - Attachment is obsolete: true
Attached image After patch —
(In reply to Pavel Ivanov [:ivanovpavel] from comment #6) > Created attachment 731449 [details] > After patch Looks good, thanks!
Attachment #728745 - Flags: review?(sjochimek) → review?(kgrandon)
Comment on attachment 728745 [details] patch for Gaia repo Don't really like the !important in the PR, but the syntax is ugly if we try to override building blocks. Would like to see BB less specific in this case.
Attachment #728745 - Flags: review?(kgrandon) → review+
Landed in master: https://github.com/mozilla-b2g/gaia/commit/2e6c8426c222dfd8b774c5f3caeffa83d293a9f2
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Depends on: 857247
Whiteboard: visual design, UX-P1, yedo → visual design, UX-P1, yedo, gaia-uplift
Whiteboard: visual design, UX-P1, yedo, gaia-uplift → visual design, UX-P1, yedo, gaia-uplift, landed in uxbranch
Master Build Unagi Build: 20130404030955 Gecko http://hg.mozilla.org/mozilla-central/rev/c232bec6974d Gaia 29660ec0a4ad7c90d22e33852e1601d45f781e03 Kernel: Dec 5th Verified in the Master build above. All spacing issues have been addressed.
Marking verified based on comment 10.
Status: RESOLVED → VERIFIED
Comment on attachment 728745 [details] patch for Gaia repo NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): Visual Design Non-Conformity User impact if declined: High, perceived app quality Testing completed: Yes Risk to taking this patch (and alternatives if risky): Low String or UUID changes made by this patch:
Attachment #728745 - Flags: approval-gaia-v1?
Attachment #728745 - Flags: approval-gaia-v1? → approval-gaia-v1+
Uplifted commit 2e6c8426c222dfd8b774c5f3caeffa83d293a9f2 as: v1-train: b0838274226851851817f8184a40514839a33f2e
status-b2g18: affected → fixed
Whiteboard: visual design, UX-P1, yedo, gaia-uplift, landed in uxbranch → visual design, UX-P1, yedo, landed in uxbranch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: