Closed Bug 845122 Opened 9 years ago Closed 9 years ago

Backlog - Add support for caret selection via touch (text selection in text fields)

Categories

(Tracking Graveyard :: Metro Operations, defect, P2)

x86_64
Windows 8.1
defect

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: jimm, Unassigned)

References

()

Details

(Whiteboard: feature=backlog)

Attachments

(1 file)

Once bug 832957 lands, selection will have improved quite a bit. However those patches do not include caret selection support. 

STR:

1) open a page with a text area with text in it
2) tap once to set the caret location

result: the caret is positioned but there is no metro singular monocle to drag select text displayed.
Blocks: 844658
No longer blocks: 831985
No longer depends on: 832957
Requesting triage on this. Selection in text inputs is tricky with the way our current selection logic works. We can probably get this working the way metro apps work, but it will take some effort.

Eventually we need to move all the front end touch selection code down into dom where it will be simpler to implement and can be shared by all our mobile platforms. (bug 783488 might be shaping up into that effort.)
Whiteboard: [metro-mvp?]
Whiteboard: [metro-mvp?] → [metro-mvp?][selection]
Flags: needinfo?(asa)
(In reply to Jim Mathies [:jimm] from comment #1)
> Eventually we need to move all the front end touch selection code down into
> dom where it will be simpler to implement and can be shared by all our
> mobile platforms. (bug 783488 might be shaping up into that effort.)

Chatted with ehsan about this a bit. He's convinced a good portion of this logic should stay in the front end with dom support through new apis. Either way we will need to do work in both areas to get input drag selection working such that it matches the microsoft spec.
Blocks: 831909
No longer blocks: metrov1triage
No longer blocks: 844658
I'd be pretty bummed out if we had to ship v1 with this shortcoming. 

I see this in the Firefox address field too. Is that the same issue or a different one?
Flags: needinfo?(asa)
Summary: Add support for caret selection via touch → Add support for caret selection via touch (text selection in text fields)
Whiteboard: [metro-mvp?][selection] → [selection] feature=work
No longer blocks: metrov1triage
(In reply to Asa Dotzler [:asa] from comment #3)
> I'd be pretty bummed out if we had to ship v1 with this shortcoming. 
> 
> I see this in the Firefox address field too. Is that the same issue or a
> different one?

Chrome and content will likely share the same I code so my guess is the behavior would be the same. I think android implements both separately but I'd bet they would prefer to avoid that if they could.
Hi Asa.  Do you want to make this a Change Story.  If so, what priority level would you like?  If it is low, I'll put it in triage as a nice to have.  If it is high, we can add it to IT#4 or IT#5.  Your call.
Flags: needinfo?(asa)
Whiteboard: [selection] feature=work → [selection]
Blocks: metrov1it4
Flags: needinfo?(asa)
Summary: Add support for caret selection via touch (text selection in text fields) → Change - Add support for caret selection via touch (text selection in text fields)
Whiteboard: [selection] → feature=change c=Content_features u=metro_firefox_user p=0
Priority: -- → P1
Whiteboard: feature=change c=Content_features u=metro_firefox_user p=0 → feature=change c=Content_features u=metro_firefox_user p=20
Assignee: nobody → jmathies
Needs to be converted into a new story for Jim.
Blocks: metrov1onhold
No longer blocks: 831909, metrov1it4
Flags: needinfo?(asa)
Summary: Change - Add support for caret selection via touch (text selection in text fields) → Story - Add support for caret selection via touch (text selection in text fields)
Whiteboard: feature=change c=Content_features u=metro_firefox_user p=20 → feature=story c=tbd u=tbd p=20
Flags: needinfo?(asa)
Hey Jim.  Here's the story Asa has prepared.  Please outline the work items.  If you feel the number of work items will carry over an iteration please let me know and we'll divide it.  Once you have the work items laid out let me know and I'll move everything over to Iteration #4.
Blocks: 831671
No longer blocks: 831985
Component: Input → General
Flags: needinfo?(jmathies)
Priority: P1 → P2
QA Contact: jbecerra
Whiteboard: feature=story c=tbd u=tbd p=20 → feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=20
(In reply to Marco Mucci [:MarcoM] from comment #8)
> Hey Jim.  Here's the story Asa has prepared.  Please outline the work items.
> If you feel the number of work items will carry over an iteration please let
> me know and we'll divide it.  Once you have the work items laid out let me
> know and I'll move everything over to Iteration #4.

I can't break this up into new bugs without discovery work. My guess is this is likely going to take some time and involve some dom / layout work. Which implies it may span across multiple iterations.
Flags: needinfo?(jmathies)
That's not a problem.  Just make a work item for discovery work and dom/layout work.  These items will represent the initial work for the story.  Once you have the required knowledge of how to move forward afterwards, you can create new work items which can be applied to the next iteration if need be.  That's a way to divide across iterations.
Depends on: 851054
Whiteboard: feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=20
Summary: Story - Add support for caret selection via touch (text selection in text fields) → Backlog - Add support for caret selection via touch (text selection in text fields)
Whiteboard: feature=backlog
Assignee: jmathies → nobody
QA Contact: jbecerra
Blocks: metrov1it4
No longer blocks: metrov1onhold
Depends on: caret-sel
Component: General → Metro Operations
Product: Firefox for Metro → Tracking
Version: Trunk → ---
Marco, I'm not currently using bug 851054 so I think we should transfer the points back over here or to bug 851388, which is where I've start my initial work. I think we can just resolve bug 851054 out.
Flags: needinfo?(mmucci)
Hi Jim.  Thanks for the update.  I can make those changes.  With the work you've outlined in Bug 851388, do you need any adjustment to the 8 point value?
Flags: needinfo?(mmucci)
(In reply to Marco Mucci [:MarcoM] from comment #12)
> Hi Jim.  Thanks for the update.  I can make those changes.  With the work
> you've outlined in Bug 851388, do you need any adjustment to the 8 point
> value?

For now I think we should go with the original 20 pts. Once I get a little more into it we might be able to break it up into separate chunks with smaller point values.
OK Jim.  Sounds good.  I'll make the change.  When you are ready to break it down let me know.
(In reply to Marco Mucci [:MarcoM] from comment #14)
> OK Jim.  Sounds good.  I'll make the change.  When you are ready to break it
> down let me know.

Why is this bug now a "backlog" bug and bug 851388 a story? This bug was originally the story, as it has the writeup on it. Also, what is a "backlog" bug?
Just a place holder for organizing.  I'll edit/invalidate this when we outline how Bug 851388 can be broken across iterations.
No longer depends on: caret-sel
No longer blocks: metrov1it4
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
OS: Windows 8 Metro → Windows 8.1
Product: Tracking → Tracking Graveyard
You need to log in before you can comment on or make changes to this bug.