845155 - Story - NewUI - Location Permission info app bar

Status: VERIFIED FIXED

(Tracking Graveyard :: Metro Operations, defect, P2)

Description

[Asa Dotzler [:asa]]

Attachment: NewUI - Location Permission info app bar

Comment 1

[Marco Mucci [:MarcoM]]

Hey Matt, just leave me a comment if this will be landing tonight.  If I see the comment, I'll add it to the iteration and mark it as Resolved.

Comment 2

[Matt Brubeck (:mbrubeck)]

(In reply to Marco Mucci [:MarcoM] from comment #1)
> Hey Matt, just leave me a comment if this will be landing tonight.  If I see
> the comment, I'll add it to the iteration and mark it as Resolved.

Bug 847626 landed on inbound today, so I think this is code complete and can be verified as soon as that patch makes it into a nightly build.

Comment 3

[Marco Mucci [:MarcoM]]

Thanks Matt.  Do you think the patch will make it in tonight?

Comment 4

[Matt Brubeck (:mbrubeck)]

Looks like it missed the latest inbound merge, so it probably won't be in tonight's nightly build.

Comment 5

[Marco Mucci [:MarcoM]]

No problem.  We'll through it in as part of Iteration #4.

Comment 6

[Matt Brubeck (:mbrubeck)]

QA notes:

* Contrary to step 3 in attachment 718200 [details], the geolocation info bar should *not* disappear when the user taps the content area.  Only the pop-up blocker bar should do this.  See bug 847620 comment 2.

* The button labels are different from the ones in attachment 718200 [details].  Instead they should match shorlander's mockup in attachment 719299 [details].  See bug 838211 comment 25.

Comment 7

[juan becerra [:juanb]]

Tested on 2013-03-15 using Nightly built from http://hg.mozilla.org/mozilla-central/rev/0f7261e288f2
- Tested with sample url in user story as well as MDN examples. When you visit one of these sites you get the location permission info bar and it prompts you whether you want to share your location with the site in question.
- The "Learn more..." link takes you to https://www.mozilla.org/en-US/firefox/geolocation/
- The button elements I observed, Share Location, Always for this Site, Never for this Site as well as the dismiss X.
- Verified the functionality for each of these buttons.
- Made sure touching or clicking on the content area did not dismiss the location permission app bar.
- Also tested that creating a new tab and coming back to the one with the location permissions app bar still had the app bar.

Comment 8

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130825030201
Built from http://hg.mozilla.org/mozilla-central/rev/01576441bdc6

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in user story and got expected result.